Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove new style water #3760

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@RealBadAngel
Copy link
Contributor

commented Feb 21, 2016

No description provided.

@paramat

This comment has been minimized.

Copy link
Member

commented Feb 21, 2016

Don't bother with menu stuff yet as #3740 has to go in first, i'll try to get that merged very soon today.

@Calinou

This comment has been minimized.

Copy link
Member

commented Feb 21, 2016

👍, it breaks smooth lighting (which does not affect new style water, but does affect waving water) and is not that needed with the waving water we have now.

@RealBadAngel RealBadAngel force-pushed the RealBadAngel:new_style_water branch to 117df3d Feb 21, 2016

@BlockMen

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2016

We already have a discussion for this, a seconds location for that is not needed. Closing until a decission is made.
Discussion: #3734

@BlockMen BlockMen closed this Feb 21, 2016

@paramat

This comment has been minimized.

Copy link
Member

commented Feb 22, 2016

? That's an issue, this is the PR, re-opening.

@RealBadAngel now that simple settings menu has returned please can you remove the new style water setting from that? Then i'll +1.

@paramat paramat reopened this Feb 22, 2016

@kaeza

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2016

👎 I like NSW. And yes, I (intentionally) don't use smooth lighting, so I don't have the visual inconsistency.

@paramat paramat added this to the 0.4.14 milestone Feb 24, 2016

@paramat

This comment has been minimized.

Copy link
Member

commented Feb 25, 2016

Simple setting menu will be updated in another PR.
👍

@est31

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2016

👍

@paramat

This comment has been minimized.

Copy link
Member

commented Feb 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.