Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4057 (weird Shift behavior) #4074

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@neoascetic
Copy link
Contributor

commented May 2, 2016

I don't know if this internally more Irrlicht's problem, but I find nothing bad in using isprint instead of != 0.

What about special symbols in the console: it definitely Irrlicht's issue and I've created patch request for it. Hope it will be merged soon.

Fix #4057 (weird Shift behavior)
I don't know if this internally more Irrlicht's problem, but I find
nothing bad in using `isprint` instead of `!= 0`.

What about special symbols in console: it definitely Irrlicht's issue
and I've created [patch request](https://sourceforge.net/p/irrlicht/patches/313/) for it.
Hope it will be merged soon.
@neoascetic

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2016

Any thoughts?

@paramat paramat added the Bugfix label Jul 3, 2016

@@ -611,7 +611,7 @@ bool GUIChatConsole::OnEvent(const SEvent& event)
prompt.nickCompletion(names, backwards);
return true;
}
else if(event.KeyInput.Char != 0 && !event.KeyInput.Control)
else if(isprint(event.KeyInput.Char) && !event.KeyInput.Control)

This comment has been minimized.

Copy link
@Zeno-

Zeno- Jul 3, 2016

Contributor

I wonder which header is already including <ctype.h>

Anyhow, I don't really understand what this and the following lines with the casts are actually doing (not what you added, what's already there). 'KeyInput.Char' is of type 'wchar_t' isn't it? So, a) I don't know if isprint() is really meant to be used with something that's wchar_t; and b) I don't know what the lines below are doing.

This comment has been minimized.

Copy link
@sfan5

sfan5 Oct 2, 2016

Member

It looks like it's converting event.KeyInput.Char (which isn't a real wchar_t apparently) from UTF-8 to a codepoint.

@neoascetic

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2016

Bump, just because why not?

@sfan5 sfan5 force-pushed the minetest:master branch to 09f1a0c Dec 21, 2016

@neoascetic neoascetic closed this Dec 24, 2016

@neoascetic neoascetic deleted the krondor-game:fixes/4057 branch Dec 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.