Fix #4057 (weird Shift behavior) #4074
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know if this internally more Irrlicht's problem, but I find nothing bad in using `isprint` instead of `!= 0`. What about special symbols in console: it definitely Irrlicht's issue and I've created [patch request](https://sourceforge.net/p/irrlicht/patches/313/) for it. Hope it will be merged soon.
|
Any thoughts? |
| @@ -611,7 +611,7 @@ bool GUIChatConsole::OnEvent(const SEvent& event) | |||
| prompt.nickCompletion(names, backwards); | |||
| return true; | |||
| } | |||
| else if(event.KeyInput.Char != 0 && !event.KeyInput.Control) | |||
| else if(isprint(event.KeyInput.Char) && !event.KeyInput.Control) | |||
There was a problem hiding this comment.
I wonder which header is already including <ctype.h>
Anyhow, I don't really understand what this and the following lines with the casts are actually doing (not what you added, what's already there). 'KeyInput.Char' is of type 'wchar_t' isn't it? So, a) I don't know if isprint() is really meant to be used with something that's wchar_t; and b) I don't know what the lines below are doing.
There was a problem hiding this comment.
It looks like it's converting event.KeyInput.Char (which isn't a real wchar_t apparently) from UTF-8 to a codepoint.
|
Bump, just because why not? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this internally more Irrlicht's problem, but I find nothing bad in using
isprintinstead of!= 0.What about special symbols in the console: it definitely Irrlicht's issue and I've created patch request for it. Hope it will be merged soon.