Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to improve performance by combining 6 vectors into one using a struct #4076

Conversation

Projects
None yet
7 participants
@ShadowNinja
Copy link
Member

commented May 2, 2016

Alternative to #3534.

@SmallJoker

This comment has been minimized.

Copy link
Member

commented May 3, 2016

Better than the original pull 👍

@PilzAdam

This comment has been minimized.

Copy link
Contributor

commented May 3, 2016

And is this attempt successful? Does it improve performance?

@sofar

This comment has been minimized.

Copy link
Member

commented May 4, 2016

And is this attempt successful? Does it improve performance?

I'm succumbing to spontaneous combustion due to the suspense myself :D

@gregorycu

This comment has been minimized.

Copy link
Contributor

commented May 8, 2016

This will improve performance on windows debug builds for sure.

Also, is better code. More structure than a lot of vectors for each thing.

@est31

This comment has been minimized.

Copy link
Contributor

commented May 13, 2016

👍

@paramat paramat added the One approval label Sep 3, 2016

@paramat

This comment has been minimized.

Copy link
Member

commented Sep 14, 2016

Shall we merge this then? @ShadowNinja Build fail is the usual thing that can be ignored.

@paramat

This comment has been minimized.

Copy link
Member

commented Sep 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.