Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escapes fix #4090

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@Ekdohibs
Copy link
Member

commented May 5, 2016

These commits fix two issues that were introduced with escape sequence removal.
The first one was with dropdowns, that didn't return their argument, but the argument with escape sequences processed.
The second was that running unescape_string after unescape_enriched broke minetest.formspec_escape (for strings with special characters inside escape sequences).

@paramat paramat added this to the 0.4.14 milestone May 5, 2016

@paramat

This comment has been minimized.

Copy link
Member

commented May 5, 2016

Sorry this type of code is beyond me so i can't approve it, however code style seems ok.

@paramat paramat added Bugfix and removed Bug labels May 7, 2016

@Ekdohibs Ekdohibs force-pushed the Ekdohibs:escapes_fix branch May 7, 2016

Ekdohibs added some commits May 5, 2016

Make dropdowns show the string that was their argument.
This makes it work even if it contains escape sequences,
which didn't work before.
Run unescape_enriched *after* unescape_string.
Doing it the other way round was a mistake, since it breaks
minetest.formspec_escape with escape sequences that contain
special characters.

@Ekdohibs Ekdohibs force-pushed the Ekdohibs:escapes_fix branch to 1520690 May 7, 2016

@Ekdohibs

This comment has been minimized.

Copy link
Member Author

commented May 7, 2016

@Ekdohibs Ekdohibs closed this May 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.