Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep scroll position constant in ChatBuffer::deleteOldest() #4092

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@kahrl
Copy link
Contributor

commented May 5, 2016

Fixes #4051.

@kahrl kahrl changed the title Keep scroll position constant in ChatBuffer::deleteOldest(). Keep scroll position constant in ChatBuffer::deleteOldest() May 5, 2016

@kahrl kahrl force-pushed the kahrl:chatscrollfix branch to b1928b3 May 5, 2016

@paramat paramat added this to the 0.4.14 milestone May 5, 2016

@paramat

This comment has been minimized.

Copy link
Member

commented May 5, 2016

Thanks.

@Fixer-007

This comment has been minimized.

Copy link
Contributor

commented May 5, 2016

Very important fix of annoying problem.
UPD: tested it and it fixes the bug for me.
👍

@est31 est31 added the Bug label May 6, 2016

@est31

This comment has been minimized.

Copy link
Contributor

commented May 6, 2016

I think some people had this issue with my server console as well.

@est31

This comment has been minimized.

Copy link
Contributor

commented May 6, 2016

(second part of #3492)

@tenplus1

This comment has been minimized.

Copy link
Contributor

commented May 6, 2016

It would be nice to have a /clear command as well to remove ALL chat and start fresh.

@Zeno- Zeno- added the One approval label May 6, 2016

@Zeno-

This comment has been minimized.

Copy link
Contributor

commented May 6, 2016

LGTM

@paramat paramat added Bugfix and removed Bug labels May 7, 2016

@paramat

This comment has been minimized.

Copy link
Member

commented May 8, 2016

@paramat paramat closed this May 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.