New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decorations: Fix decoration height check errors #4402

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@paramat
Member

paramat commented Aug 3, 2016

Fix height check comparison from '>=' to '>'.
Fix getHeight() for schematic decorations to account for
'deco place center y' flag and for how normal placement
sinks schematic 1 node into the ground.

Jungletrees were not being placed at y = 46, y = 47 despite
having an acceptable 16 nodes of height above ground surface.
////////////////////////////////////////////////////

Fix for #4401
Tested.

Decorations: Fix decoration height check errors
Fix height check comparison from '>=' to '>'.
Fix getHeight() for schematic decorations to account for
'deco place center y' flag and for how normal placement
sinks schematic 1 node into the ground.

Jungletrees were not being placed at y = 46, y = 47 despite
having an acceptable 16 nodes of height above ground surface.
@kwolekr

This comment has been minimized.

Show comment
Hide comment
@kwolekr

kwolekr Aug 4, 2016

Contributor

👍

Contributor

kwolekr commented Aug 4, 2016

👍

@paramat paramat added the One approval label Aug 4, 2016

@paramat

This comment has been minimized.

Show comment
Hide comment
@paramat
Member

paramat commented Aug 5, 2016

@paramat paramat closed this Aug 5, 2016

@paramat paramat deleted the paramat:schemgetheight branch Aug 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment