Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera: Higher frequency limit for view/hand bobbing and footsteps #4457

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@paramat
Copy link
Member

commented Aug 20, 2016

'm_view_bobbing_speed' controls the frequency of view bobbing,
hand bobbing and footsteps, it was limited to 40 (walking frequency)
so did not increase if player speed was modified by a 'speed buff' or
sprinting mod.
This commit raises the limit to 70 which is suitable for sprinting,
while still being limited prevents excessive frequency when 'fast move'
is used.
//////////////////////////////////////////////////////

Rebased version of #1908
It seems there is some confusion over this PR, i hope my explanation is clear.
A good way to test this for yourself is to enable 'autorun' then use 'W' to switch between normal walking and 'fast move', because 'fast move' is so fast this will make the bob / footstep frequency hit its limit.

'm_view_bobbing_speed' gets its value from the length of the player speed vector, so is proportional to player speed (of course) but has a limit in place to avoid excessively fast sound events and bobbing when using 'fast move' (20 nodes per second == 45mph). Currently the limit is set (wrongly) at walking speed / frequency (40).

We have a 'set physics override' API so modifying player speed is common in mods. It is also easily done by modifying player speed in .conf or advanced settings.

'fast move' is not 'Minetest run', it's an unrealstic admin/cheat/superpower, however it does look better when a higher maximum frequency is allowed.

@paramat paramat changed the title Camera: Allow up to double speed view/hand bobbing Camera: Allow up to double speed view/hand bobbing, footsteps Aug 21, 2016

@paramat paramat force-pushed the paramat:maxbobspeed branch Aug 23, 2016

@paramat paramat changed the title Camera: Allow up to double speed view/hand bobbing, footsteps Camera: Higher frequency limit for view/hand bobbing and footsteps Aug 23, 2016

@paramat paramat added the Bugfix label Aug 23, 2016

@paramat

This comment has been minimized.

Copy link
Member Author

commented Aug 23, 2016

Tuned to 70 and updated.

@paramat paramat added Bugfix and removed Bugfix labels Aug 23, 2016

@sofar

This comment has been minimized.

Copy link
Member

commented Aug 25, 2016

👍

@rubenwardy

This comment has been minimized.

Copy link
Member

commented Aug 25, 2016

👍 tested. Works nicely, good feedback for speed
I can't see any problems with this.

Camera: Higher frequency limit for view/hand bobbing and footsteps
Rebased and tuned version of Calinou's original pull request.

'm_view_bobbing_speed' controls the frequency of view bobbing,
hand bobbing and footsteps, it was limited to a maximum of 40 (walking
frequency) so did not increase if player speed was modified by a
'speed buff', a sprinting mod or modified in .conf or advanced
settngs.

This commit raises the limit to 70 which is suitable for sprinting.

@paramat paramat force-pushed the paramat:maxbobspeed branch to 32b121b Aug 26, 2016

@paramat

This comment has been minimized.

Copy link
Member Author

commented Aug 26, 2016

@paramat paramat closed this Aug 26, 2016

@paramat paramat deleted the paramat:maxbobspeed branch Aug 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.