Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transient Forceloads #4498

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@raymoo
Copy link
Contributor

commented Sep 3, 2016

Adds a flag to forceload_block which lets you turn off persistence for that forceload.

@est31

View changes

builtin/game/forceloading.lua Outdated
blocks_forceloaded[hash] = blocks_forceloaded[hash] - 1
local relevant_table
local other_table
if transient then

This comment has been minimized.

Copy link
@est31

est31 Sep 3, 2016

Contributor

maybe you can export this into a little (local) helper function?

This comment has been minimized.

Copy link
@raymoo

raymoo Sep 3, 2016

Author Contributor

Do you mean to make a function that takes a boolean and returns relevant_table, other_table?

@est31

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2016

Otherwise 👍

@est31

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2016

Related issue: #4470

@raymoo raymoo force-pushed the raymoo:tempforce branch to 0a655c5 Sep 3, 2016

@raymoo

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2016

I addressed the line comment, I think.

@est31 est31 added the One approval label Sep 3, 2016

@t4im

t4im approved these changes Oct 2, 2016

Copy link
Contributor

left a comment

Looks good to me. The conditions around block incrementing/decrementing took a moment to check, but it looks correct to me.

@sfan5

This comment has been minimized.

Copy link
Member

commented Oct 2, 2016

👍

@sfan5 sfan5 added >= Two approvals and removed One approval labels Oct 2, 2016

@paramat

This comment has been minimized.

Copy link
Member

commented Oct 3, 2016

@paramat paramat closed this Oct 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.