Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builtin: Change error to warning for light_source > 14 #4538

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@paramat
Copy link
Member

commented Sep 21, 2016

As requested 3aefa5d#commitcomment-19105454
The light source value of 15 is widespread and likely to persist for months, some players may not know how to edit the value.
Tested.

@paramat paramat added the Trivial label Sep 21, 2016

paramat referenced this pull request Sep 21, 2016

Register.lua: Throw error if node 'light_source' > core.LIGHT_MAX
Add 'core.LIGHT_MAX = 14' to builtin/game/constants.lua with the intention
to replace misplaced 'default.LIGHT_MAX = 14' in Minetest Game.
Add comment in light.h requiring the constant be changed in both places.
Add lighting bug warning to note in lua_api.txt.
There are hundreds of mod uses of 15 which causes a lighting bug.
@est31

This comment has been minimized.

Copy link
Contributor

commented Sep 21, 2016

👍

@paramat paramat added One approval and removed Trivial labels Sep 21, 2016

@sofar

This comment has been minimized.

Copy link
Member

commented Sep 21, 2016

👍

@paramat

This comment has been minimized.

Copy link
Member Author

commented Sep 21, 2016

@paramat paramat closed this Sep 21, 2016

@paramat paramat deleted the paramat:lightwarning branch Sep 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.