Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSM] add `on_item_use` #5544

Merged
merged 1 commit into from May 6, 2017

Conversation

4 participants
@red-001
Copy link
Contributor

commented Apr 8, 2017

Part of #5394

lua_getglobal(L, "core");
lua_getfield(L, -1, "registered_on_item_use");

// Push data

This comment has been minimized.

Copy link
@Dumbeldor

Dumbeldor Apr 9, 2017

Contributor

To avoid repeating code several times I proposed it in a MR: https://github.com/minetest/minetest/pull/5548/files#diff-fc5bd7f599797bce163af517e57a314c

@@ -189,6 +189,46 @@ bool ScriptApiClient::on_punchnode(v3s16 p, MapNode node)
return blocked;
}

bool ScriptApiClient::on_item_use(ItemStack item, PointedThing pointed)

This comment has been minimized.

Copy link
@nerzhul

nerzhul Apr 10, 2017

Member

const ItemStack &, const PointedThing &

@nerzhul nerzhul referenced this pull request Apr 12, 2017

Closed

[CSM] Second Roadmap #5394

15 of 27 tasks complete
@nerzhul

This comment has been minimized.

Copy link
Member

commented Apr 27, 2017

@red-001 can you fix this PR please ?

@red-001 red-001 force-pushed the red-001:csm_on_item_use branch from 56dc4fb to f159dc7 May 6, 2017

@nerzhul

nerzhul approved these changes May 6, 2017

@nerzhul nerzhul added the One approval label May 6, 2017

@SmallJoker
Copy link
Member

left a comment

LGTM

@nerzhul nerzhul merged commit 5ebf8f9 into minetest:master May 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@red-001 red-001 deleted the red-001:csm_on_item_use branch May 6, 2017

@nerzhul nerzhul moved this from In Progress to Done in Server-sent Client Side Modding May 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.