Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder TileSpec. #5591

Merged
merged 1 commit into from Apr 18, 2017

Conversation

Projects
None yet
3 participants
@sofar
Copy link
Member

commented Apr 14, 2017

Put accessed members that are needed by updateFastFaceRow()
all in the same cacheline.

Reorder TileSpec.
Put accessed members that are needed by updateFastFaceRow()
all in the same cacheline.
@sofar

This comment has been minimized.

Copy link
Member Author

commented Apr 14, 2017

Note: because this is still copied verbatim in hot path, this doesn't actually solve much I think :/

@sofar

This comment has been minimized.

Copy link
Member Author

commented Apr 14, 2017

Note: The holes were found with pahole. I verified after this change that the TileSpec is pretty well organized and the gaps are almost gone, but it's still 2 cachelines :/

@sfan5 sfan5 added the Performance label Apr 14, 2017

@nerzhul nerzhul merged commit 93c1d51 into minetest:master Apr 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@juhdanad juhdanad referenced this pull request Apr 21, 2017

Merged

Soft node overlay #5186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.