New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSM] add screenshot api lua #5674

Merged
merged 3 commits into from Apr 29, 2017

Conversation

@Dumbeldor
Contributor

Dumbeldor commented Apr 28, 2017

Show outdated Hide outdated doc/client_lua_api.md
@nerzhul

Okay for me

@SmallJoker

LGTM

@sofar sofar added this to the 0.4.16 milestone Apr 29, 2017

@sofar sofar closed this Apr 29, 2017

@sofar sofar reopened this Apr 29, 2017

@sofar

This comment has been minimized.

Show comment
Hide comment
@sofar

sofar Apr 29, 2017

Member

My bad, "back" button did something I didn't expect

Member

sofar commented Apr 29, 2017

My bad, "back" button did something I didn't expect

@sofar

This comment has been minimized.

Show comment
Hide comment
@sofar

sofar Apr 29, 2017

Member

Do we really want this? This will make it trivial to fill up someones drive with files.

Member

sofar commented Apr 29, 2017

Do we really want this? This will make it trivial to fill up someones drive with files.

@Ekdohibs

This comment has been minimized.

Show comment
Hide comment
@Ekdohibs

Ekdohibs Apr 29, 2017

Member

For that a few other changes (like maybe client API that will make predictions to the world state), I think what we really want is two Lua APIs: one that would be for locally-installed client mods, and one for client mods sent from server. Of course, they would share most of the API calls, but locally-installed mods do not need as much security and would be allowed API calls like this one, while mods sent from server would be much more limited with these API calls, but would probably however be allowed to make calls that predict changes to the world state or that modify the player physics. Since we only have the former for the moment, I don't think this should be an objection to this PR, as clients can have that code only if they install the mod themselves.

Member

Ekdohibs commented Apr 29, 2017

For that a few other changes (like maybe client API that will make predictions to the world state), I think what we really want is two Lua APIs: one that would be for locally-installed client mods, and one for client mods sent from server. Of course, they would share most of the API calls, but locally-installed mods do not need as much security and would be allowed API calls like this one, while mods sent from server would be much more limited with these API calls, but would probably however be allowed to make calls that predict changes to the world state or that modify the player physics. Since we only have the former for the moment, I don't think this should be an objection to this PR, as clients can have that code only if they install the mod themselves.

@nerzhul nerzhul merged commit 19960e2 into minetest:master Apr 29, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@rubenwardy

This needed rate limiting

while 1 do
    minetest.take_screenshot()
end
@nerzhul

This comment has been minimized.

Show comment
Hide comment
@nerzhul

nerzhul Apr 29, 2017

Member

ofc now we can do it, rate limiting seems lgtm to code

Member

nerzhul commented Apr 29, 2017

ofc now we can do it, rate limiting seems lgtm to code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment