Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instant dig bug #5728 #5743

Closed
wants to merge 2 commits into from

Conversation

Projects
5 participants
@lisacvuk
Copy link
Contributor

commented May 10, 2017

Fixed issue #5728, I hope I did it the right way.

@pilino1234

This comment has been minimized.

Copy link
Contributor

commented May 10, 2017

Use 1 tab (instead of 4 spaces) for indent to fix the code style

@lisacvuk

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2017

@lisacvuk

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2017

@pilino1234 I did use tabs, but apparently my editor changed it to spaces :( I'll fix it

@Fixer-007

This comment has been minimized.

Copy link
Contributor

commented May 10, 2017

Please rename it to something better.

@nerzhul nerzhul changed the title Fixed #5728 Fix instant dig bug #5728 May 10, 2017

@pilino1234

This comment has been minimized.

Copy link
Contributor

commented May 11, 2017

I'd say this is [trivial], [bugfix], possibly even [high priority], can this be merged soon please?

@nerzhul nerzhul added this to the 0.4.16 milestone May 11, 2017

@nerzhul

This comment has been minimized.

Copy link
Member

commented May 12, 2017

it will be merged when 2 coredev will test it. I will do it, ti's a sensible feature, i hope we don't trigger cheating (after merging this) just 1 month before release

@pilino1234

This comment has been minimized.

Copy link
Contributor

commented May 12, 2017

i hope we don't trigger cheating

you're fixing cheating by merging this though 😉

@lisacvuk

This comment has been minimized.

Copy link
Contributor Author

commented May 12, 2017

@pilino1234 Not everyone knows about this bug. Merging the fix would alert them

@pilino1234

This comment has been minimized.

Copy link
Contributor

commented May 12, 2017

Lolwut. So if we don't report bugs they don't exist either and nobody will care about it??

If there's a bug in the game, it should be fixed asap, especially if it affects gameplay like this one does. Merging this isn't gonna alert anybody any more than the discussion of it already has, so there's that.

@nerzhul

This comment has been minimized.

Copy link
Member

commented May 13, 2017

Sorry but you don't fix it: https://youtu.be/G0u35fDmoow , you improved it :(

@nerzhul nerzhul closed this May 13, 2017

@nerzhul nerzhul removed the Blocker label May 13, 2017

@nerzhul nerzhul added this to Done in Minetest 0.4.16 May 13, 2017

@paramat paramat removed this from the 0.4.16 milestone May 17, 2017

@Fixer-007

This comment has been minimized.

Copy link
Contributor

commented May 19, 2017

Funny, you fixed diam pickaxe-shovel instamining and introduced instamining for wooden shovel or pickaxe, it simply instamines without any preparations. Can confirm.

@lisacvuk

This comment has been minimized.

Copy link
Contributor Author

commented May 19, 2017

@paramat

This comment has been minimized.

Copy link
Member

commented May 20, 2017

Seems this PR does not fix the bug #5728 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.