Mainmenu: Fix problems with recently added "game" type #5770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmallJoker
force-pushed
the
fix_mod_select
branch
from
f699f28
to
db51c75
Compare
nerzhul
reviewed
May 18, 2017
kilbith
reviewed
May 18, 2017
src/client.cpp
Outdated
| @@ -168,7 +168,7 @@ void Client::initMods() | |||
| if (!string_allowed(mod.name, MODNAME_ALLOWED_CHARS)) { | |||
| throw ModError("Error loading mod \"" + mod.name + | |||
| "\": Mod name does not follow naming conventions: " | |||
| "Only chararacters [a-z0-9_] are allowed."); | |||
| "Only characterss [a-z0-9_] are allowed."); | |||
kilbith
reviewed
May 18, 2017
builtin/mainmenu/modmgr.lua
Outdated
| @@ -252,7 +252,7 @@ function modmgr.render_modlist(render_list) | |||
| break | |||
| end | |||
| end | |||
| elseif v.typ == "game_mod" or v.typ == "game" then | |||
| elseif string.find(v.typ, "game") then | |||
There was a problem hiding this comment.
You really need find here and there? Prefer sub when it's possible.
SmallJoker
force-pushed
the
fix_mod_select
branch
2 times, most recently
from
39eafb4
to
6ae3424
Compare
|
@nerzhul Instead of creating a function for this simple task, I extended the mod table to mark all the game content with the key/value |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problems pointed out in http://irc.minetest.ru/minetest-dev/2017-05-18#i_4927850
Caused by #5367