Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update credits #5800

Closed
wants to merge 7 commits into from

Conversation

@Zeno-
Copy link
Contributor

commented May 22, 2017

No description provided.

@nerzhul
Copy link
Member

left a comment

Please don't listen ABBA and move kahrl & est31 &kwoelr to previous developers

@nerzhul nerzhul added this to the 0.4.16 milestone May 22, 2017

@Zeno- Zeno- added the Trivial label May 22, 2017

@nerzhul

This comment has been minimized.

Copy link
Member

commented May 22, 2017

wtf

@SmallJoker
Copy link
Member

left a comment

EDIT: +1 for listening to ABBA. Don't forget to move me into the core dev list.

@paramat

This comment has been minimized.

Copy link
Member

commented May 22, 2017

sofart's comment disappeared, user 'sofart' is not found in Github on a search.

@Zeno-

This comment has been minimized.

Copy link
Contributor Author

commented May 22, 2017

This is currently a "placemarker PR". Essentially to remind us to update this file before release.

@red-001

This comment has been minimized.

Copy link
Contributor

commented May 22, 2017

@paramat I guess GitHub support might have responded to my report then.

@nerzhul nerzhul added this to To Do in Minetest 0.4.16 May 23, 2017

Zeno- added some commits May 23, 2017

Update
* move gregorcu to previous contribs
* add red-001 to active contribs
* move Sokomine to previous contribs
Move VanessaE to active
She is very active within the community and the community consists of more than those making PRs
"TeTpaAka",
"Jean-Patrick G (kilbith) <jeanpatrick.guerrero@gmail.com>",
"Diego Martínez (kaeza) <kaeza@users.sf.net>",
"Dániel Juhász (juhdanad) <juhdanad@gmail.com>",
"Rogier <rogier777@gmail.com>",
"red-001 <red-001@outlook.ie>",
"Vanessa Ezekowitz (VanessaE) <vanessaezekowitz@gmail.com>",

This comment has been minimized.

Copy link
@nerzhul

nerzhul May 23, 2017

Member

no amount of PR in the core engine, should be removed

This comment has been minimized.

Copy link
@Zeno-

Zeno- May 24, 2017

Author Contributor

Quite often there are PRs that need live testing before they are added to the engine. Often the person who does this is Vanessa, on her actual servers (not "test" servers). To me that is contributing and a valuable one. I don't think Vanessa cares if her name is in this section or not, but I believe it does belong here. Developing is about more than just coding.

Edit: Just so this is clear, I am not going to put my foot down and refuse to move the entry back to where it was. This PR is not going to be merged until just before release though, so it can stay where I've moved it to for now so that it can be /rationally/ discussed. I really do believe that development is more than just coding: consistent and detailed bug reports, testing PRs, writing documentation (amongst many others) are all examples of things that are required and don't involve any programming at all.

@@ -28,7 +28,7 @@ local core_developers = {
"Loic Blot (nerzhul/nrz) <loic.blot@unix-experience.fr>",
"Matt Gregory (paramat)",
"est31 <MTest31@outlook.com>",
"Craig Robbins (Zeno) <craig.d.robbins@gmail.com>",
"Craig Robbins (Zeno) <craig.d.robbins@gmail.com> (Listens to ABBA)",

This comment has been minimized.

Copy link
@nerzhul

nerzhul May 23, 2017

Member

don't forget to remove this :)

This comment has been minimized.

Copy link
@Zeno-

Zeno- May 24, 2017

Author Contributor

I hope I don't forget :D

@Fixer-007

This comment has been minimized.

Copy link
Contributor

commented May 23, 2017

BTW, I've seen conversation on #minetest-dev on who to include or not.
"About" tab seems to me too much complicated, maybe instead:

  • make just two categories: Engine and Minetest Game (without split of active/nonactive, you can start with active contributors on top)
  • define criteria. for example amount of code added/changed/commits/etc, so you can define major contributors in meaningful way
  • list them, in both categories at the end add "end other contributors"
  • in the end of about tab add separate sentence "Thanks to translators who participated in the project", you can even make third category just for them, listing active language translators and their languages.
@@ -28,7 +28,7 @@ local core_developers = {
"Loic Blot (nerzhul/nrz) <loic.blot@unix-experience.fr>",
"Matt Gregory (paramat)",

This comment has been minimized.

Copy link
@paramat

paramat May 23, 2017

Member

Just 'paramat' please, lower case 'p'.

This comment has been minimized.

Copy link
@Zeno-

Zeno- May 24, 2017

Author Contributor

Just clarifying: you're asking for your real name to be removed?

@paramat

This comment has been minimized.

Copy link
Member

commented May 23, 2017

Including MTGame contributors may not be a good idea, it's a separate project theoretically no different to any other subgame.

@Fixer-007

This comment has been minimized.

Copy link
Contributor

commented May 23, 2017

Then subgame should have some kind of description info via some button with list of mods and contributors.

@paramat

This comment has been minimized.

Copy link
Member

commented May 23, 2017

Another suggestion to consider: In each release list all those who have commits in the release. This would restrict numbers but also mean we don't have to draw a line at some arbitrary number of commits.
But 'previous contributors' would have to remain a restricted number to avoid getting too big.

@est31

This comment has been minimized.

Copy link
Contributor

commented May 24, 2017

@Zeno- has asked me via IRC whether I want something changed about my entry.

The current entry is okay.

"est31 <MTest31@outlook.com>",
"Craig Robbins (Zeno) <craig.d.robbins@gmail.com>",
"paramat",
"Craig Robbins (Zeno) <craig.d.robbins@gmail.com> (Dancing Queen)",

This comment has been minimized.

Copy link
@SmallJoker

SmallJoker May 24, 2017

Member

Untrue statement. You might feel like a queen and dance but this doesn't make you to a queen.

This comment has been minimized.

Copy link
@DS-Minetest

DS-Minetest May 24, 2017

Contributor

I suggest Dancing Person feeling like a Queen or Dancing Pseudoqueen or Dancing Quasiqueen.

@Zeno-

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2017

Too controversial for something this trivial. Closing.

@Zeno- Zeno- closed this May 28, 2017

@Zeno- Zeno- reopened this May 28, 2017

@nerzhul

This comment has been minimized.

Copy link
Member

commented May 29, 2017

paramat see #5840

@nerzhul nerzhul moved this from To Do to Done in Minetest 0.4.16 May 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.