Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dungeons: Add setting to prevent projecting dungeons #6051

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@paramat
Copy link
Member

commented Jun 26, 2017

Prevents dungeons generating into ignore nodes in ungenerated mapchunks,
which can occasionally result in a dungeon projecting from the terrain.
////////////////

Addresses #5204
Requested by several players and nerzhul.
Tested.
Set to true by default because that is my preference.
Screenshots of projecting dungens are here #5204 (comment)

WIth this PR i have to, and i'm sorry i have to, insist that the default is true.
This is my favourite feature of MT mapgen and has been for years.
These are not common and create interesting structures in the landscape that inspire conversion into player bases or homes.

@nerzhul

This comment has been minimized.

Copy link
Member

commented Jun 26, 2017

Thanks for the PR

@paramat

This comment has been minimized.

Copy link
Member Author

commented Jun 26, 2017

Tested.

@paramat

This comment has been minimized.

Copy link
Member Author

commented Jun 27, 2017

Some screenshots of interesting looking protruding dungeons are here #5204 (comment)

Consider that if those were sliced at terrain level they, in my opinion, would not look any better and would be less interesting. Also consider these protruding dungeons are fairly rare, most are sliced at terrain level, some variety is good to have.
Many dungeons intersect the surface, most are sliced at the surface, i consider that the others are mostly preserved or partially ruined above the surface.
They make interesting ruins to see in the distance and discover, and with some additions make stunning homes or bases for players. Their mostly complete structure makes them easier to convert.

@paramat paramat force-pushed the paramat:pokydungeons branch from b786514 to 6eed464 Jun 27, 2017

Dungeons: Add setting to prevent projecting dungeons
Prevents dungeons generating into ignore nodes in ungenerated mapchunks,
which can occasionally result in a dungeon projecting from the terrain.

@paramat paramat force-pushed the paramat:pokydungeons branch from 6eed464 to e2a7d7c Jun 27, 2017

@paramat paramat changed the title Dungeons: Add setting to prevent protruding dungeons Dungeons: Add setting to prevent projecting dungeons Jun 27, 2017

@paramat paramat removed the WIP label Jun 27, 2017

@paramat

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2017

@paramat

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2017

@paramat paramat closed this Jul 2, 2017

@paramat paramat referenced this pull request Jul 2, 2017

Closed

Dungeons outside #5204

@paramat paramat deleted the paramat:pokydungeons branch Jul 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.