Move the nametag back to the top of the player #6179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it's not the correct fix, as now we can change model, it's not a fixed size like before. Can you find the correct value of the model instead ? |
TeTpaAka
force-pushed
the
master
branch
2 times, most recently
from
7d8b34e
to
4fcce8b
Compare
|
Updated. |
nerzhul
reviewed
Jul 27, 2017
src/camera.h
Outdated
| @@ -157,7 +160,8 @@ class Camera | |||
| } | |||
|
|
|||
| Nametag *addNametag(scene::ISceneNode *parent_node, | |||
| std::string nametag_text, video::SColor nametag_color); | |||
| std::string nametag_text, video::SColor nametag_color, | |||
There was a problem hiding this comment.
nice, can you just fix to use const ref on the string and the v3f please ?
paramat
reviewed
Jul 27, 2017
src/content_cao.cpp
Outdated
| @@ -895,8 +895,11 @@ void GenericCAO::addToScene(ITextureSource *tsrc) | |||
| scene::ISceneNode *node = getSceneNode(); | |||
| if (node && m_prop.nametag != "" && !m_is_local_player) { | |||
| // Add nametag | |||
| v3f pos; | |||
| pos.Y = m_prop.collisionbox.MaxEdge.Y + 0.1f; | |||
There was a problem hiding this comment.
Probably needs to be higher, as before it was position + 1.1, which was 2.1 above foot position, the collisionbox top is at 1.77 above foot position, so add 0.3f for consistency and some clearence?
paramat
added
the
Action / change needed
read the actual height of the collisionbox
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 11, 2019
read the actual height of the collisionbox
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 23, 2019
read the actual height of the collisionbox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6174