Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change README to Markdown format, add LICENSE.txt #6244

Merged
merged 1 commit into from Aug 18, 2017
Merged

Change README to Markdown format, add LICENSE.txt #6244

merged 1 commit into from Aug 18, 2017

Conversation

rubenwardy
Copy link
Member

@rubenwardy rubenwardy commented Aug 12, 2017 •
edited

@rubenwardy rubenwardy mentioned this pull request Aug 12, 2017
Closed
@rubenwardy rubenwardy added @ Documentation Low priority Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements labels Aug 12, 2017
@bigfoot547
Copy link
Contributor

bigfoot547 commented Aug 12, 2017 •
edited

WE NEED MORE SHIELDS! 😄
</offtopic>

@sfan5
Copy link
Member

sfan5 commented Aug 13, 2017

shouldn't LICENSE.txt also get installed?

@rubenwardy
Copy link
Member Author

shouldn't LICENSE.txt also get installed?

done

WE NEED MORE SHIELDS! 😄

:D
any suggestions for useful ones?

@rubenwardy rubenwardy mentioned this pull request Aug 13, 2017
Closed
SmallJoker
SmallJoker reviewed Aug 13, 2017
View reviewed changes
README.md Outdated

General options:

* BUILD_CLIENT - Build Minetest client
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like how the indents are lost in the Markdown projection. How about putting these params into a code block or table?

Copy link
Contributor

@paramat paramat Aug 13, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this section is hard on the eyes now.
Otherwise looks good.

@nerzhul
Copy link
Member

nerzhul commented Aug 13, 2017

another PR ? please close redundant PR then

@rubenwardy
Copy link
Member Author

another PR ? please close redundant PR then

Already did that when I opened this PR

@nerzhul nerzhul merged commit a039d98 into minetest:master Aug 18, 2017
@rubenwardy rubenwardy deleted the readmemd branch August 18, 2017 09:12
@rubenwardy rubenwardy restored the readmemd branch August 18, 2017 09:12
osjc pushed a commit to osjc/minetest that referenced this pull request Jan 11, 2019
@rubenwardy @osjc
Change README to Markdown format, add LICENSE.txt (minetest#6244)
98baeb1
osjc pushed a commit to osjc/minetest that referenced this pull request Jan 23, 2019
@rubenwardy @osjc
Change README to Markdown format, add LICENSE.txt (minetest#6244)
93ced98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paramat paramat paramat left review comments

@nerzhul nerzhul nerzhul approved these changes

@SmallJoker SmallJoker SmallJoker approved these changes

Assignees
No one assigned
Labels
@ Documentation Low priority Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements >= Two approvals ✅ ✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rubenwardy @bigfoot547 @sfan5 @nerzhul @SmallJoker @paramat