Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unkown nodes: Provide position on interact #6505

Merged
merged 2 commits into from Oct 7, 2017

Conversation

Projects
None yet
2 participants
@SmallJoker
Copy link
Member

commented Oct 7, 2017

Solves #6502

### Inventory actions ###
2017-10-07 11:33:43: ERROR[Server]: Item "lab:invtest" not defined at position (30,5,-58)
2017-10-07 11:33:43: ERROR[Server]: Item "lab:invtest" not defined at position (30,5,-58)
2017-10-07 11:33:48: ERROR[Server]: Item "lab:invtest" not defined at position (30,5,-58)
2017-10-07 11:33:48: ERROR[Server]: Item "lab:invtest" not defined at position (30,5,-58)
2017-10-07 11:33:52: ERROR[Server]: Item "lab:invtest" not defined at position (30,5,-58)

### Digging unknown nodes ###
2017-10-07 11:33:58: ERROR[Server]: Item "lab:invtest" not defined at position (31,5,-59)
2017-10-07 11:33:59: ERROR[Server]: Item "lab:invtest" not defined at position (31,5,-59)
2017-10-07 11:33:59: ACTION[Server]: singleplayer digs lab:invtest at (31,5,-59)
2017-10-07 11:34:01: ERROR[Server]: Item "lab:invtest" not defined at position (31,5,-60)
2017-10-07 11:34:02: ERROR[Server]: Item "lab:invtest" not defined at position (31,5,-60)
2017-10-07 11:34:02: ACTION[Server]: singleplayer digs lab:invtest at (31,5,-60)

### Trying to placing unknown items (same as before) ###
2017-10-07 11:34:07: ERROR[Server]: Item "lab:invtest" not defined
2017-10-07 11:34:07: ERROR[Server]: Item "lab:invtest" not defined
2017-10-07 11:34:07: ERROR[Server]: Item "lab:invtest" not defined
@nerzhul

nerzhul approved these changes Oct 7, 2017

Copy link
Member

left a comment

except the little style preference, 👍

@@ -225,7 +226,10 @@ bool ScriptApiItem::getItemCallback(const char *name, const char *callbackname)
if(lua_type(L, -1) != LUA_TTABLE)
{

This comment has been minimized.

Copy link
@nerzhul

nerzhul Oct 7, 2017

Member

as you are very near this brace can you fix the condition style please ?

@nerzhul nerzhul added the One approval label Oct 7, 2017

@nerzhul nerzhul merged commit f547452 into minetest:master Oct 7, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

sfan5 added a commit that referenced this pull request Nov 19, 2017

Unkown nodes: Provide position on interact (#6505)
* Unkown nodes: Provide position on interact

@sfan5 sfan5 referenced this pull request Dec 5, 2017

Closed

Backport 0.4 #6746

sfan5 added a commit that referenced this pull request Dec 5, 2017

Unkown nodes: Provide position on interact (#6505)
* Unkown nodes: Provide position on interact

@SmallJoker SmallJoker deleted the SmallJoker:unknown_pos branch Dec 14, 2017

t0ny2 pushed a commit to t0ny2/minetest that referenced this pull request Jan 23, 2018

Unkown nodes: Provide position on interact (minetest#6505)
* Unkown nodes: Provide position on interact

sfan5 added a commit that referenced this pull request Feb 2, 2018

Unkown nodes: Provide position on interact (#6505)
* Unkown nodes: Provide position on interact

sfan5 added a commit that referenced this pull request Feb 3, 2018

Unkown nodes: Provide position on interact (#6505)
* Unkown nodes: Provide position on interact

sfan5 added a commit that referenced this pull request Apr 21, 2018

Unkown nodes: Provide position on interact (#6505)
* Unkown nodes: Provide position on interact

sfan5 added a commit that referenced this pull request May 13, 2018

Unkown nodes: Provide position on interact (#6505)
* Unkown nodes: Provide position on interact

SmallJoker added a commit that referenced this pull request Jun 3, 2018

Unkown nodes: Provide position on interact (#6505)
* Unkown nodes: Provide position on interact

osjc added a commit to osjc/minetest that referenced this pull request Jan 11, 2019

Unkown nodes: Provide position on interact (minetest#6505)
* Unkown nodes: Provide position on interact

osjc added a commit to osjc/minetest that referenced this pull request Jan 23, 2019

Unkown nodes: Provide position on interact (minetest#6505)
* Unkown nodes: Provide position on interact
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.