New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth handler: Player deletion & Iterator #6741

Merged
merged 2 commits into from Dec 6, 2017

Conversation

Projects
None yet
4 participants
@sfan5
Member

sfan5 commented Dec 5, 2017

No description provided.

@nerzhul

nerzhul approved these changes Dec 5, 2017

@nerzhul nerzhul added the One approval label Dec 5, 2017

@rubenwardy

Just some documentation suggestions.

I wonder if it's worth adding a function like minetest.get_player_auth_iterator()

Show outdated Hide outdated doc/lua_api.txt
Show outdated Hide outdated doc/lua_api.txt
@rubenwardy

👍 when this is done

Show outdated Hide outdated doc/lua_api.txt

sfan5 added some commits Dec 5, 2017

Support iterating over the auth database
There was no way to do this previously and a recent commit
broke doing this the "hacky" way by accessing `core.auth_table`.

@SmallJoker SmallJoker merged commit 4edf087 into minetest:master Dec 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sfan5 sfan5 deleted the sfan5:auth_changes2 branch Dec 6, 2017

t0ny2 pushed a commit to t0ny2/minetest that referenced this pull request Jan 23, 2018

Auth handler: Player deletion & Iterator (#6741)
* Add player deletion method to auth handler (fixes #6653)
* Support iterating over the auth database

There was no way to do this previously and a recent commit
broke doing this the "hacky" way by accessing `core.auth_table`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment