Jump to conversation
Unresolved conversations (3)
@rubenwardy rubenwardy Apr 10, 2018
without this comment, I would've thought the function did nothing
src/content_sao.cpp
SmallJoker
@rubenwardy rubenwardy Apr 10, 2018
~I'd prefer these to be split into an assignment and a check, and a space between~
src/content_cao.cpp
@rubenwardy rubenwardy Dec 16, 2017
this function sounds like it sound clear children, rather than the parent too. I'd prefer two functions - `detachFromParent` and `clearChildAttachments` or `clearChildren`
Outdated
src/content_sao.cpp
SmallJoker
Resolved conversations (0)