Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hud_get return aligment, offset and size. #7006

Merged
merged 2 commits into from Feb 4, 2018

Conversation

Projects
None yet
6 participants
@lisacvuk
Copy link
Contributor

commented Feb 3, 2018

Closes #3276. Please review.

@sofar

This comment has been minimized.

Copy link
Member

commented Feb 3, 2018

Seems reasonable. Needs documentation update?

@lisacvuk

This comment has been minimized.

Copy link
Contributor Author

commented Feb 3, 2018

I was thinking about it, but the documentation already says that it 'returns the hud element definition', which it still does do.

@sofar

This comment has been minimized.

Copy link
Member

commented Feb 3, 2018

https://github.com/minetest/minetest/blob/master/doc/lua_api.txt#L5253

Looks like it always included offset and alignment in the definition, so this is almost a fix and not a feature.

👍

@lisacvuk lisacvuk changed the title Make hud_get return aligment and offset. Make hud_get return aligment, offset and size. Feb 3, 2018

@nerzhul nerzhul merged commit 4f5090f into minetest:master Feb 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

osjc added a commit to osjc/minetest that referenced this pull request Jan 11, 2019

Make hud_get return aligment, offset and size. (minetest#7006)
* Make hud_get return aligment and offset.

* Return size aswell.

osjc added a commit to osjc/minetest that referenced this pull request Jan 23, 2019

Make hud_get return aligment, offset and size. (minetest#7006)
* Make hud_get return aligment and offset.

* Return size aswell.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.