Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position entity nametags relative to selection-box #7031

Merged
merged 1 commit into from Feb 10, 2018

Conversation

Projects
None yet
3 participants
@stujones11
Copy link
Contributor

commented Feb 9, 2018

Partly addresses #7025

Trivial PR to use the selection-box instead of the collision-box to determine nametag position. This probably should have been done as part of #6218 and would have had I been aware of this usage.

@paramat

This comment has been minimized.

Copy link
Member

commented Feb 9, 2018

👍 thanks.

@paramat paramat added the One approval label Feb 9, 2018

@SmallJoker
Copy link
Member

left a comment

Works

@SmallJoker SmallJoker merged commit 617d94c into minetest:master Feb 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stujones11 stujones11 deleted the stujones11:entity-nametag branch Feb 11, 2018

minduser00 added a commit to minduser00/minetest that referenced this pull request Mar 18, 2018

osjc added a commit to osjc/minetest that referenced this pull request Jan 11, 2019

osjc added a commit to osjc/minetest that referenced this pull request Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.