Probably for debug purposes. Should be removed because another backend might come soon.

Mixed indents again EDIT: Also above. Please disable clang format for these lines when they insist on this notation.

Should be at least a warning

you can remove the else and just do a return 0

no need to order names, you can use std::unordered_map

you can remove the temp variable here

same here

if (x) delete x: conditional is not needed

should be an `std::ostringstream`

You want the whole thing to be from a constructor that gets called multiple times when an object is made? Try something sane and have `AuthDatabaseFiles` as a global object and call `readAuthFile()` directly. For example: ( Just an example. don't use this code, it's broken ) ``` extern std::unique_ptr<AuthDatabaseFiles> sqlauth; // Declare the global object. Should be in a header that does global stuff. `std::unique_ptr` to prevent memory leaks. std::unique_ptr<AuthDatabaseFiles> sqlauth = nullptr; // In a .cpp file for the header mentioned above. // In this file, you can just have something call `readAuthFile()` by doing... sqlauth = std::unique_ptr<AuthDatabaseFiles>( new AuthDatabaseFiles() ); sqlauth->readAuthFile(); ``` Boom.

Mixed indents. Please only use tabs

These functions need to be documented.

Also add to https://github.com/minetest/minetest/blob/master/build/android/jni/Android.mk EDIT: Same for the unittest file.

brace removal

`const auto`

does this even work without a `&`?

can be `auto`

this is just an implementation detail of the sqlite db, but I guess it can't be avoided to have it in here.

is sqlite's (u)int big enough to hold timestamps beyond 2038?

wouldn't `REPLACE INTO` have the same effect?

same

this can be a const method

missing space before parenthesis

const auto

nice :)

don't duplicate this code part, use a private function to perform the loop accross the two write functions

exactly same problems there.

code style

you must use a begin and commit function to ensure data integrity there in a single write transaction

std::time_t

name & pass should be const

Just to have it said: Last login exists since almost four years but our auth mechanism didn't add dummy values if they didn't exist. However, I think we can consider this as a feature to clean up really old, unused accounts.

Superfluous return EDIT: Also found in functions in the file auth database code.

Superfluous check and return.

Nothing is returned here.

no need for a temp object here, affect it directly

for (const auto &p: authEntry.privileges)

can you store AuthDatabase pointers in a unique_ptr please ? There are some possible leaks here when exceptions are triggered

const std::string &

Can you make auth be a specific Lua object instead of a static function API ? It can be better to have an auth object to manipulate

return 0 should be sufficient here

with the std::next ? for (auto &p : authEntry.privileges) is sufficient

please add an UNIQUE index on the name field as it's unique, this will prvent the ugly limit 1 suggestion

Superfluous. `return 0` does the same, also bracket removal: ```C++ if (!success) return 0; ```

This is very inconsistent. On failure you're pushing nil to Lua, but not on success. I recommend to only return the pointers and push nil in the parent function.

SELECT and UPDATE: add `LIMIT 1`. It doesn't have to check the entire database. Only update: please use `SET` in capitals (trivial)

Are you getting this auth again only to get the new `id`?

Wrong formatting here and two lines above too.

Wrong formatting. Ignore Lint if they requested this.

const

const std::string &name