Jump to conversation
Unresolved conversations (10)
@rubenwardy rubenwardy Feb 3, 2019
subtraction of signed from unsigned
src/network/serverpackethandler.cpp
@rubenwardy rubenwardy Feb 3, 2019
unused variable
src/content_sao.cpp
@SmallJoker SmallJoker Feb 3, 2019
Much needed to not be bound to the 255 maximal HP; breaks compatibility.
src/client/client.cpp
@SmallJoker SmallJoker Feb 3, 2019
Non-functional change since an u16 is currently downcasted to this u8 version number on init.
src/client/client.h
@SmallJoker SmallJoker Feb 3, 2019
`s32` everywhere for HP calculations to ensure there are no over-/underflows.
src/client/content_cao.cpp
rubenwardy
@SmallJoker SmallJoker Feb 3, 2019
ID 0 is used here; might be the reason why the HUDs sometimes freak out and cannot be changed when they got this ID. Removing this code is highly recommended.
src/client/hud.cpp
@SmallJoker SmallJoker Feb 3, 2019
Backwards compatible because negative HP is not supported by the core any way.
src/content_sao.cpp
@SmallJoker SmallJoker Feb 3, 2019
Unused variable
src/content_sao.h
@SmallJoker SmallJoker Feb 3, 2019
Deprecated, see `content_sao.cpp`
src/genericobject.cpp
@SmallJoker SmallJoker Feb 3, 2019
This is read by `read_object_properties(L, -1, prop, getServer()->idef());`
src/script/cpp_api/s_entity.cpp
Resolved conversations (6)
@sfan5 sfan5 Jun 16, 2018
since you're cleaning up this function anyway: brace removal
Outdated
src/content_sao.cpp
@sfan5 sfan5 May 18, 2018
obsolete comment?
Outdated
src/server.cpp
@sfan5 sfan5 May 18, 2018
I don't think this will work, glow needs to be read from the data that is left after the `TileAnimationParams` were read
Outdated
src/network/clientpackethandler.cpp
@sfan5 sfan5 May 18, 2018
same here
Outdated
src/network/clientpackethandler.cpp
@sfan5 sfan5 May 18, 2018
this line is no longer needed
Outdated
src/network/clientpackethandler.cpp
@nerzhul nerzhul May 17, 2018
it should be const too
Outdated
src/client.h