VoxelManip: Abort if an argument is missing instead of silently doing nothing

[HybridDog]

Before this PR, you could e.g. call the calc_lighting for a non-mapgen vmanip object and nothing happened.
Now it aborts instead, the modder is informed that they did something wrong.

[SmallJoker]

I don't think that an error is appropriate here. A warning would be sufficient.

[HybridDog]

minetest/src/script/lua_api/l_vmanip.cpp

Lines 203 to 204 in 4b36a39

	if (!vm->m_area.contains(VoxelArea(pmin, pmax)))
	throw LuaError("Specified voxel area out of VoxelManipulator bounds");

An error is also used when wrong position arguments were passed in the current code.

[sfan5]

I would downgrade the "called for a non-mapgen VoxelManip" to warnings, having missing/wrong parameters as errors is fine IMO.

[rubenwardy]

I'm not sure this is a good idea. Especially as using set_data without an argument is perfectly valid, and should be solved by documentation anyway

[HybridDog]

Especially as using set_data without an argument is perfectly valid, and should be solved by documentation anyway

I think calling set_data without an argument is slower than testing if the argument is missing before calling it in lua because of less lua to core switches. According to lua_api, an argument should be passed:

minetest/doc/lua_api.txt

Line 2995 in 78a801e

* `set_data(data)`: Sets the data contents of the `VoxelManip` object

I would downgrade the "called for a non-mapgen VoxelManip" to warnings, having missing/wrong parameters as errors is fine IMO.

I agree because I think there may be some edge-cases where a vmanip object is passed to some commonly used function.

[paramat]

using set_data without an argument is perfectly valid

Is it? It doesn't fallback to anything, just does 'return 0'.

This PR is ok for me with warnings or errors.

[HybridDog]

I would downgrade the "called for a non-mapgen VoxelManip" to warnings, having missing/wrong parameters as errors is fine IMO.

done

[paramat]

👍 assuming it's tested.

[ClobberXD]

"VoxelManip:set_data() called with ..."

Same for the other throw LuaError lines?

[HybridDog]

Thanks, this makes it clear that the message refers to vmanip. I did not add the parenthesis because I think they would be confusing when the message is about missing parameters.

[paramat]

Oops yes this clarification is important.

[paramat]

👍