New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate modpack.txt and use modpack.conf instead #7892

Merged
merged 3 commits into from Jan 6, 2019

Conversation

Projects
None yet
3 participants
@rubenwardy
Copy link
Member

rubenwardy commented Nov 25, 2018

Without this, ContentDB doesn't install modpacks correctly.
It will create a mod.conf for modpacks, which is wrong and causes incorrect behaviour. ContentDB needs a config file for each type to keep some tracking information in content dirs.

Fixes #7647

Show resolved Hide resolved builtin/mainmenu/pkgmgr.lua Outdated

@rubenwardy rubenwardy added the WIP label Dec 2, 2018

@rubenwardy

This comment has been minimized.

Copy link
Member

rubenwardy commented Dec 2, 2018

I found those issues locally, and some more too

@rubenwardy rubenwardy added the Blocker label Dec 11, 2018

@paramat paramat added this to PR in Minetest 5.0.0 Dec 12, 2018

@SmallJoker

This comment has been minimized.

Copy link
Member

SmallJoker commented Dec 23, 2018

@rubenwardy Would it be possible for you to solve the issues in this PR (and rebase)? Otherwise we should move it to 5.1.0 to get towards 5.0.0 soon.

@rubenwardy

This comment has been minimized.

Copy link
Member

rubenwardy commented Dec 26, 2018

Otherwise we should move it to 5.1.0 to get towards 5.0.0 soon.

If this isn't merged, then CDB would need to be disabled in MT

@rubenwardy rubenwardy force-pushed the rubenwardy:depmodpacktxt branch 2 times, most recently from f189d6b to c51e063 Dec 26, 2018

@rubenwardy

This comment has been minimized.

Copy link
Member

rubenwardy commented Dec 26, 2018

Done

Show resolved Hide resolved doc/client_lua_api.txt Outdated

@rubenwardy rubenwardy force-pushed the rubenwardy:depmodpacktxt branch 2 times, most recently from 1ff24ee to 7cf2b2f Dec 30, 2018

@paramat paramat referenced this pull request Dec 30, 2018

Open

Fix modpack rename #7432

Show resolved Hide resolved builtin/mainmenu/pkgmgr.lua
Show resolved Hide resolved builtin/mainmenu/pkgmgr.lua

@rubenwardy rubenwardy force-pushed the rubenwardy:depmodpacktxt branch from af66efd to 1121d24 Jan 5, 2019

@nerzhul nerzhul merged commit 70bf343 into minetest:master Jan 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@paramat paramat removed this from PR in Minetest 5.0.0 Jan 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment