Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly set visibility of local player's attached objects #8342

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@PiezoU005F
Copy link

commented Mar 8, 2019

This fixes the issue of objects becoming temporarily invisible when attached to the local player while the client isn't in first person view.

I proposed this change before, but I initially had no clue what I was doing, and figuring out the best approach resulted in a few pointless commits, and eventually, the pull request became so far behind the main branch that it might have broken something if it were merged, so I decided it was better to delete it.

This time, I've kept it simple, and based the changes off of the latest version as well.

@ClobberXD

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

(Continued from #8046)

@Yukitty

This comment has been minimized.

Copy link

commented Mar 18, 2019

👍 Looks good to me.
I would have preferred != CAMERA_MODE_FIRST over > CAMERA_MODE_FIRST personally, but there is no functional difference in the present circumstance afaik.

Show resolved Hide resolved src/client/content_cao.cpp Outdated

@stujones11 stujones11 referenced this pull request Apr 9, 2019

Open

Add wield3d #2097

@rubenwardy rubenwardy force-pushed the minetest:master branch 2 times, most recently from 0e3b135 to 39c54e1 Jun 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.