Jump to conversation
Unresolved conversations (0)
Nice work!

Nice work!

All of your conversations have been resolved.

Resolved conversations (6)
@SmallJoker SmallJoker May 6, 2020
IMO this is superfluous. Modders will find use-cases for this parameter fast enough.
Outdated
doc/lua_api.txt
ClobberXD
@SmallJoker SmallJoker May 6, 2020
What can be used? `set_rotation` if so, then it's superfluous to state it here as well.
Outdated
doc/lua_api.txt
ClobberXD
@ClobberXD ClobberXD Jan 19, 2020
@SmallJoker Should this if-else block be restored as well?
src/client/content_cao.cpp
ClobberXD SmallJoker
@SmallJoker SmallJoker Jan 19, 2020
If it's only for `automatic_rotate`, please re-add the check to skip this part when it's not needed. -> `if (std::fabs(m_prop.automatic_rotate) > 0.001) { ....`
src/client/content_cao.cpp
ClobberXD SmallJoker
@Desour Desour Jun 22, 2019
You already checked for `getParent()` with `if`.
Outdated
src/client/content_cao.cpp
ClobberXD
@SmallJoker SmallJoker Apr 14, 2019
When `getParent() == nullptr`, this code can be skipped because `local_rot.Y` keeps its old value.
Outdated
src/client/content_cao.cpp
ClobberXD SmallJoker