Nice work!

Jump to conversation

Unresolved conversations (0)

Nice work!

All of your conversations have been resolved.

Resolved conversations (16)

> "(Ljava/lang/String;)V");

src/porting_android.cpp

``` FATAL_ERROR_IF(url_open == nullptr, "porting::openURLAndroid unable to find java show dialog method"); ```

src/porting_android.cpp

Wait, one more: This should reject URLs with a newline character.

src/porting.cpp

```suggestion bool openURL(const std::string &url) ```

src/porting.cpp

should be removed

src/porting.cpp

Note that I still think the regex should be removed and replaced with a simple `begins with "http://" or begins with "https://"` check

src/porting.cpp

you are passing a `std::string` so this will definitely not compile use `ShellExecuteA(NULL, NULL, url.c_str(), NULL, NULL, SW_SHOWNORMAL);`

src/porting.cpp

and `ShellExecuteA` here https://stackoverflow.com/questions/17347950/#answer-17348170

src/porting.cpp

nooooooooooooooooooooooooooooooooo even if this works fine in practice, you should use fork + execvp instead

src/porting.cpp

this button is too massive imo

builtin/mainmenu/tab_credits.lua

Don't we have a content repository URL, IIRC?

builtin/mainmenu/dlg_contentstore.lua

Textarea width must be adjusted. This button overlaps the text.

builtin/mainmenu/dlg_contentstore.lua

Misplaced reference.

src/porting_android.cpp

Also needs a description of what kind of URLs are allowed (direct domain links only).

doc/menu_lua_api.txt

```suggestion startActivity(browserIntent); ```

...t.minetest.minetest/MtNativeActivity.java

Dead code, I suppose?

builtin/mainmenu/dlg_contentstore.lua