Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rotation of attached particlespawner [no squash pls; ketchup ok] #8767

Closed

Conversation

@ClobberXD
Copy link
Contributor

ClobberXD commented Aug 9, 2019

PR created from pgimeno's commit: https://gitlab.com/pgimeno/minetest/commit/16593ff796d8a4c96a60e69d1c7e6813d8ab22f3


This PR fixes attached particle spawners not rotating with the parent object. See #8363 for more information.

Screenshot

screenshot_20190809_163916

How to test

  • Install and enable advtrains mod.
  • Launch the game.
  • Place a couple of tracks, and place a steam loco on a track.
  • Observe that the steam particle spawner is positioned exactly on the chimney, and is fixed to the object in the same position irrespective of object's rotation (this is broken in master).

This PR is ready for review. Tested; works. Fixes #8363.

This PR also fixes code-style in src/client/clientobject.h and src/client/particles.cpp in a separate commit for ease of reviewing. Pls no squash.

@SmallJoker

This comment has been minimized.

Copy link
Member

SmallJoker commented Aug 9, 2019

Thanks for this PR. The code looks good - I will test it this weekend.
If you have some time, please give them credits by either putting their name into the commit description or even changing the author.

@ClobberXD

This comment has been minimized.

Copy link
Contributor Author

ClobberXD commented Aug 10, 2019

@SmallJoker I intended to change the author too, but smth came up IRL, and I'm going AFK for 6-7 days. If this PR is going to be merged before I return, would you be able to change the author? Thanks in advance.

@SmallJoker SmallJoker force-pushed the ClobberXD:fix_particlespawner_rotation branch from 81c88bf to d3f3db9 Aug 10, 2019
@Andrey2470T

This comment has been minimized.

Copy link

Andrey2470T commented Aug 13, 2019

Like your minetest version on the git repo calls other error, any selection boxes of entitites get invisible what is impossible to fix.

src/client/content_cao.h Outdated Show resolved Hide resolved
@ClobberXD ClobberXD force-pushed the ClobberXD:fix_particlespawner_rotation branch from d3f3db9 to 2419e5f Aug 17, 2019
@ClobberXD ClobberXD changed the title Fix rotation of attached particlespawner Fix rotation of attached particlespawner [no squash pls; ketchup ok] Aug 17, 2019
@ClobberXD

This comment has been minimized.

Copy link
Contributor Author

ClobberXD commented Aug 17, 2019

Fixed a bunch of issues. Will look into why selection boxes aren't visible or "interactable" with.

This PR also fixes code-style in src/client/clientobject.h via a separate commit for ease of reviewing. Pls no squash.

@ClobberXD ClobberXD force-pushed the ClobberXD:fix_particlespawner_rotation branch 2 times, most recently from c0b9100 to ad393a9 Aug 17, 2019
Pedro Gimeno and others added 3 commits Aug 9, 2019
Co-authored-by: ANAND <ClobberXD@gmail.com>
Mainly spacing and pointer placement
@ClobberXD ClobberXD force-pushed the ClobberXD:fix_particlespawner_rotation branch from c6045be to 16a8232 Aug 17, 2019
Copy link
Member

SmallJoker left a comment

Works!

@sfan5
sfan5 approved these changes Aug 31, 2019
Copy link
Member

sfan5 left a comment

Looks fine to me.

@sfan5 sfan5 added >= Two approvals and removed One approval labels Aug 31, 2019
@SmallJoker

This comment has been minimized.

Copy link
Member

SmallJoker commented Aug 31, 2019

@SmallJoker SmallJoker closed this Aug 31, 2019
@ClobberXD ClobberXD deleted the ClobberXD:fix_particlespawner_rotation branch Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.