Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Quicktune code to util/ #8871

Open
wants to merge 1 commit into
base: master
from

Conversation

@ClobberXD
Copy link
Contributor

commented Aug 29, 2019

I very recently discovered what Quicktune actually is, but then I realised that the files were in the wrong place. src/util/ is probably a more suitable location for these files, IMO.

Tested, code compiles without errors. This PR is ready for review.

@DS-Minetest

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

I think, you also have to change this for android:

jni/src/quicktune.cpp \

And travis wants you to fix the code style.

@ClobberXD ClobberXD force-pushed the ClobberXD:util_quicktune branch from 6aea2c8 to ce4d5ca Aug 29, 2019

@ClobberXD

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

I think, you also have to change this for android

Thanks for letting me know. Done.

And travis wants you to fix the code style.

The files were added to the clang format whitelist, but the whitelist entries became invalid since the files have been moved to a different directory. Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.