Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dungeons: Remove non-functional 'projecting dungeons' setting #8897

Merged
merged 1 commit into from Sep 8, 2019

Conversation

@paramat
Copy link
Member

commented Sep 3, 2019

Closes #8875
See issue for details. This setting is now non-functional for some currently unknown reason, projecting dungeons never occur.
If i can get projecting dungeons working again (i hope so) i will do so by controlling that from a new dungeon parameter instead of a global setting, so removing this setting is a good idea anyway.

If you want to test:
Use

mg_flags = light,nocaves,dungeons,nodecorations,biomes
mgv7_np_dungeons = {
    offset      = 8,
    scale       = 0,
    spread      = (67, 67, 67),
    seed        = 10325,
    octaves     = 3,
    persistence = 0.5,
    lacunarity  = 2.0,
    flags       =
}

to cause 8 dungeons per mapchunk in mgv7, fly around and check none 'project' out of the ground.

@paramat

This comment has been minimized.

Copy link
Member Author

commented Sep 8, 2019

@paramat paramat merged commit 4682c7b into minetest:master Sep 8, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@paramat paramat deleted the paramat:projectdung branch Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.