Jump to conversation
Unresolved conversations (0)
Nice work!

Nice work!

All of your conversations have been resolved.

Resolved conversations (6)
@sfan5 sfan5 Apr 29, 2022
should mention "Note that functions will be dumped to bytecode by this function but will always error upon attempting to deserialize them (unless mod security is disabled), so this is not useful for that purpose."
doc/persistence.adoc
@benrob0329 benrob0329 Jan 3, 2022
This feels a little _too_ opinionated to me. I think that the configuration interface is fine if used properly, and is likely a lot faster for the simple k/v storage it's supposed to be than serialization. Noting that the `minetest.settings` object is global is good, even separating that part out into something like `CAUTION: This sets global settings, don't set global settings.` might be good.
Outdated
doc/persistence.adoc
@benrob0329 benrob0329 Jan 3, 2022
```suggestion Userdata objects (like `ItemStack` for example) aren't supported. Threads (coroutines) aren't supported either. ```
Outdated
doc/persistence.adoc
@benrob0329 benrob0329 Jan 3, 2022
This isn't super clear on what kind of function serialization is supported. Both bytecode and non-bytecode versions of functions can be deserialized (assuming the safe flag is false), but only non-bytecode functions can be serialized (iirc).
Outdated
doc/persistence.adoc
@benrob0329 benrob0329 Jan 3, 2022
```suggestion Minetest alternatively offers a serializer implemented in Lua, which serializes to Lua source code, available as `minetest.serialize` and `minetest.deserialize`. The following values are supported: ```
Outdated
doc/persistence.adoc
@benrob0329 benrob0329 Jan 3, 2022
Can you give an example of one which solves the issues presented by the Minetest implementation?
Outdated
doc/persistence.adoc
appgurueu