Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add moonflower mod #165

Closed
wants to merge 1 commit into from
Closed

Add moonflower mod #165

wants to merge 1 commit into from

Conversation

RealBadAngel
Copy link
Contributor

Adding flower that opens only at night
Source of fluorescent dye (to come with separate patch)

@Zeg9
Copy link
Contributor

Zeg9 commented May 31, 2013

This mod is so great...
Fluorescent dye is a good idea, maybe wait for it before merging this?

@RealBadAngel
Copy link
Contributor Author

The dye have to be separate patch because it will modify dye mod. I want rebuild crafting of dyes to use mortar + pestle item instead of cookin (which is an absurd). We dont have to follow stupid mc ways.

@PilzAdam
Copy link
Contributor

Why? This just adds (another) flower that is kinda useless since we already can get all dyes.
It also doesnt change anything at all in the gameplay, so why should this be merged?

@RealBadAngel
Copy link
Contributor Author

This adds an original content, and makes way to obtain fluorescent dye. Nothing like this is aviable in game atm.
So, THATS WHY.
And ofc it willl be useseless without further usage of it. Thats my point.
Collect flowers that glow at night, get the dye, craft dye +glass for example to get glowing glass...

@PilzAdam
Copy link
Contributor

If we follow this as a guideline to merge mods upstream then we would have to take the whole Mod Release forum and throw it in. This doesnt end good.
Content should not just be added because its "original" or "not MC like". It should make a game together with the other things.
Also, I dont see anything about new dye or glowing glass in this pull request.

@HybridDog
Copy link
Contributor

I think here it would be better to use PseudoRandom instead of math.random.

@Zeg9
Copy link
Contributor

Zeg9 commented Jun 7, 2013

@HybridDog (don't know where I should write you that): could you reopen your pull requests about obsidian brick and lavacooling in minetest_game ?

@HybridDog
Copy link
Contributor

@Zeg9 Thanks for remembering me.

@HybridDog
Copy link
Contributor

@Zeg9 Now I need to tell you that I haven't downloaded your obsidianbrick texture and the ompldr doesn't work.

@Jordach
Copy link
Contributor

Jordach commented Jun 8, 2013

#169 does this already and has glowing dye + glowing mese.

@HybridDog HybridDog mentioned this pull request Jun 11, 2013
@HybridDog
Copy link
Contributor

#175 (comment)

@C1ffisme
Copy link

This dosen't need the "duplicate" label anymore. The duplicate has been closed.

@paramat
Copy link
Contributor

paramat commented Sep 14, 2015

Lovely idea but i think a mod thing, 👎 from PilzAdam and myself. Other devs opinions? shall we close this now?

@MirceaKitsune
Copy link
Contributor

Years ago when I implemented the initial Moonflower, it was intended for inclusion into minetest_game. It wanted it to be an unique item that gave the default Minetest a personality of its own, similar to what redstone or zombie pigmen are for Minecraft.

With this considered, it's of course the choice of other developers whether it's good for default MTG or not. Personally I think it works best as a rare item that spawns occasionally on specific biomes.

@RHRhino
Copy link
Contributor

RHRhino commented Sep 14, 2015

It's ridiculous that minetest devs need YEARS to decide for pull requests and issues - moonflower mod is just one example for that ... 😠

@MirceaKitsune
Copy link
Contributor

@RHRhino Things do happen a bit slowly, I agree. I can understand caution in some decisions, but Minetest could advance a lot faster if pull requests were solved sooner.

@RHRhino
Copy link
Contributor

RHRhino commented Sep 14, 2015

A bit slowly? This pull request is from March 2013 - as slow as a dead snail would be more appropriate! I think it's just fustrating for people who try to help to develope minetest if they have to wait ages just to get their pull request merged or a clear answer that it doesn't fit into minetest or minetest_game.

@paramat
Copy link
Contributor

paramat commented Sep 14, 2015

Yes this is why today i'm giving old PRs some attention. The other MTGame devs seem to be very busy at the moment so i'm doing a lot of dev work and asking for approvals from them.

@HybridDog
Copy link
Contributor

This pull request is from March 2013 - as slow as a dead snail would be more appropriate!

l think a dead snail disappears in less then a year.
If pull requests of people don't get attention, the people don't make new ones, e.g. because of possible conflicts.

@rubenwardy
Copy link
Member

I like this, 👍
I like Jordach's PR more, however.

@paramat
Copy link
Contributor

paramat commented Sep 14, 2015

Hi @RealBadAngel just notifiying you because it's over a year since your last comment.

@RHRhino
Copy link
Contributor

RHRhino commented Sep 14, 2015

@rubenwardy what does Jordach's PR have different?

@paramat
Copy link
Contributor

paramat commented Oct 29, 2015

Closing due to age of PR and 2 👎

@paramat paramat closed this Oct 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet