New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beds in all wool colours #1923
Comments
Updated point 2, wool pixel hues vary greatly so we cannot use 'colourise' or 'multiply' texture modifiers, or hardware colourisation, 15 separate textures are needed for the coloured blankets. |
@paramat I have been trying to figure out what is the contrast and brightness adjustment that has been done from the normal red wool texture to the bed texture. However, while I get close to the same effect, I do notice that the bed texture brightness and contrast are not uniform. |
Close is good enough. I just tiled the texture and yes the edges have been darkened which is not good or at best unnecessary, uniform is fine. |
Awesome, thanks for clarification! |
Any part of the textures which is coloured should be uniform, no edge darkening. |
Without edge darkening the texture looks a bit flat. |
Perfect. DS-Minetest it has to be uniform as it part of a larger area of coloured blanket. |
@hkzorman all coloured blankets should have that lower contrast of the red one, but they don't all need to be darkened by the same amount. For example already dark colours won't need darkening and some colours may not look as good darkened (such as yellow) so i'll leave that to your artistic judgement. |
@paramat These are all the wool textures modified for bed usage. I will use these base textures in all bed textures that require color. Are these ok to you? |
The light green and the orange could be brighter imho. |
I'm already half-way modifying the textures, so I won't proceed further until you are ok with them. |
Looking at the small images they seem ok but i will compare against the wools in Gimp too. |
Just looked at black and blue so far. The average hue varies between your bed blue and the wool blue. I tried reducing contrast of the wool texture to see how the process is done, and i can see it's not easy to preserve the hue of each pixel, what process did you use? EDIT: |
In trying to do the process myself i can see it is difficult. I started with reducing contrast, then used 'HSV' tool too boost saturation multiple times, then i needed to reduce contrast again, boost saturation again. I think it's more important to have hue matching than to reproduce the reduction of contrast. Perhaps we can use the wool colours as they are or just make them darker, no reduction of contrast? |
Let's get another opinion on this. |
Just looked at the brown. It's an unpleasant oversaturated red-brown now, pixel hues are very different. I won't do the others. Let's see if we take a different approach. |
Other devs are ok with exactly matching the wool textures http://irc.minetest.net/minetest-dev/2017-11-10#i_5132745 |
So, no texture modification, just use the same wool texture for all colors? |
For each bed colour, simply use the corresponding wool texture unchanged. |
Ok, no problem, I will do so.
For the darkest ones, I applied around -25 brightness and -25 contrast and nothing else. No problem for the change of direction, I understand that some of my textures weren't of the best colors! I will work on these now. |
Yes in trying to process one myself it seems that the contrast change can change hue values, i had not expected this so sorry for that suggestion. |
@paramat No problem, I should be able to come up with a PR within this week. |
See https://github.com/minetest/minetest_game/blob/master/mods/flowers/init.lua#L29 for how to register large numbers of nodes by iterating through a data table. The registration API of beds can remain the same, then alias the old beds to the new red bed. |
Looks good. |
Instead of registering nodes for beds in all colors maybe use hardware colors instead and optimize the textures? |
See point 2 in first post. |
See what I quoted and read what I replied to that quote. |
If you originally quoted point 2 in your comment, sorry. If so, wool textures would have to be changed too as the intent is to have beds match wool. However, our wool textures look good because they have varying hue pixels. The problem with hardware colouring is that it forces you to use a single base texture and applies a single hue to it, this removes a lot of possibilities and results in poorer looking textures. |
Yes. Change wool and beds to use hardware coloring exclusively and optimize the textures to look good in all colors.
[citation needed] |
Would also break all texture packs and alter the appearence of builds. |
0.5.0 is a breaking release, so … 😄
If it has limitations those limitations should be removed by implementing it differently instead of not using it, I guess. |
We're only breaking compatibility, not mods (apart from player position), worlds or texture packs. |
There is no stability guarantee for texture packs, they have been broken in the past. (Same goes for "appearance of builds" by the way.) |
True, but '0.5 breakage' still doesn't mean breaking texture packs. |
@hkzorman any progress? |
No problem, 0.5 is not soon. |
IMO the requirement of a rose (when there was only one color of bed anyway) was a poor, shameful mistake, not a feature. |
Yes i agree. It tried to mimic MC too closely. |
EDIT: I disapprove of this now 👎
///////////////////////////
#1794 has some discussion on this, it was closed due to several issues and an unsuitable approach.
I request that beds are made available in all wool colours, instead of just 'MC red'.
This will also solve the often expressed frustration of requiring a rose to make a bed.
The text was updated successfully, but these errors were encountered: