Spawn mod: Also reposition players on respawn #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested. |
SmallJoker
reviewed
Jun 5, 2018
mods/spawn/init.lua
Outdated
| -- position. | ||
|
|
||
| minetest.register_on_newplayer(function(player) | ||
| if not searched then | ||
| success = search() | ||
| searched = true | ||
| end | ||
| if success then | ||
| player:setpos(spawn_pos) |
There was a problem hiding this comment.
Deprecated naming. set_pos (also for register_on_respawnplayer)
EDIT: This callback (including return true) can be defined as regular function and registered in newplayer and respawnplayer using the same function name.
There was a problem hiding this comment.
Ah of course, ok on both.
To avoid respawn position being possibly very distant from new player spawn position.
|
Updated and retested. |
SmallJoker
reviewed
Jun 6, 2018
| end | ||
| end | ||
|
|
||
| minetest.register_on_newplayer(function(player) |
There was a problem hiding this comment.
Shorter: minetest.register_on_newplayer(on_spawn)
SmallJoker
approved these changes
Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, respawn after player death could result in an engine spawn position significantly far from the new player mod spawn position, which is also inconsistent with spawning behaviour without the mod. Depending on the mapgen (some have large areas of sea) and the scale of heat and humidity noises, spawn mod position could be 100s-1000s of nodes away from engine spawn.