Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some useful groups (tool types, mushroom) #2323

Closed
Wuzzy2 opened this issue Feb 25, 2019 · 6 comments
Closed

Add some useful groups (tool types, mushroom) #2323

Wuzzy2 opened this issue Feb 25, 2019 · 6 comments

Comments

@Wuzzy2
Copy link
Contributor

@Wuzzy2 Wuzzy2 commented Feb 25, 2019

As per discussion from https://forum.minetest.net/viewtopic.php?f=5&t=22075&p=344407#p344407, I propose to add some tool-related groups that will be useful for mods:

  • pickaxe=1: For all pickaxe items
  • axe=1: For all axe items
  • shovel=1: For all shovel items
  • hoe=1: For all hoe items
  • sword=1: For all sword items

Justification: There are many many uses for these groups: In crafting, for achivements (e.g. “craft any pickaxe”) and whatnot.

Moreover, I also suggest:

  • mushroom=1: For the fruit body of mushrooms (Red Mushroom, Brown Mushroom, but not huge mushroom blocks should they ever be added)

Justification:

just because there are mods such as nsspf and mushrooms_redo that add mushrooms, and a universal reference ought to be available.

@Ezhh

This comment has been minimized.

Copy link
Member

@Ezhh Ezhh commented Mar 4, 2019

I'd like to see more use of groups for the same reason given above, and these all seem like perfectly reasonable ones to add.

@cx384

This comment has been minimized.

Copy link
Contributor

@cx384 cx384 commented Mar 9, 2019

I also would like to have this groups:

  • stone_with_ore=1: For every stone with ore.

Justification: Item drop modifications like dropping the node or multiple ore drops. And many other things like quarrys, vein mine, ore detection, ...
This would be a little bit like the spreading_dirt_type group.

  • sandstone=1: For all sandstones (bricks and blocks included like group stone)

Justification: There is already a sand and stone group but sandstone belongs to none of them.

Groups for crystals, lumps, ingots and metals would be nice too, but I don't think they would worth it.

@HybridDog

This comment has been minimized.

Copy link
Contributor

@HybridDog HybridDog commented Mar 15, 2019

I'd like to have the hot and melts group. The snow mod uses them to test if an ice node should melt.
https://github.com/Splizard/minetest-mod-snow/blob/dc799f344f15ade2f8fb66cd6745dafb317c8515/src/abms.lua#L23
hot was removed in 60f6564, but some nodes are hot and do not ignite, e.g. torch
For the melts group, a temperature and on_melt nodedef field could be added.

@paramat

This comment has been minimized.

Copy link
Member

@paramat paramat commented Mar 16, 2019

MTG doesn't have melting nodes, so the snow mod should code this itself by overriding nodedefs.
New groups should be useful within MTG too, not added just for optional mods, otherwise the bloat would be massive, with most of the bloat unused.

@Ezhh

This comment has been minimized.

Copy link
Member

@Ezhh Ezhh commented Mar 16, 2019

I support the ones wuzzy identified in the top post because I can imagine nice clear cut uses for them. I am less sure about the others.

@An0n3m0us

This comment has been minimized.

Copy link
Contributor

@An0n3m0us An0n3m0us commented Jun 10, 2019

@paramat Should this be closed because of #2378?

@SmallJoker SmallJoker closed this Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.