New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wool to make use of global dye.dyes #2366
Conversation
To be precise: wool does not depend on dyes, as any other mod could add items with the required item groups. Well, I guess it's fine to link it with dye because it's loaded anyway 🤷♂️ |
I'm neutral on this, but reducing dependencies is useful for those who use certain MTG mods unchanged in their own games. |
The order of the tables is different, but this should make no problems. Look at both tables if you want.minetest_game/mods/wool/init.lua Lines 1 to 17 in aee5ba6
minetest_game/mods/dye/init.lua Lines 5 to 21 in aee5ba6
Imo, this makes sense. 👍 |
Yes, it does make sense in the context of MTG 👍 |
Thank you very much. |
affects two files:
I see no reason why 'wool' should establish local dye definitions by ignoring the global
dye.dyes