Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dry grass spread on default:dirt again #2687

Merged
merged 1 commit into from Jun 16, 2020
Merged

Make dry grass spread on default:dirt again #2687

merged 1 commit into from Jun 16, 2020

Conversation

paramat
Copy link
Contributor

@paramat paramat commented May 25, 2020

Possibly attends to #2684

Commit c32b8ad possibly went too far in removing dry grass spreading behaviour in old savanna areas. This PR intends to restore dry grass spreading behaviour in the old savanna areas that use default:dirt and default:dirt_with_dry_grass.

Intentions:

  • A default:dry_grass plant placed on default:dirt should eventually turn the default:dirt into default:dirt_with_dry_grass.
  • default:dirt_with_dry_grass placed next to default:dirt should eventually turn the default:dirt into default:dirt_with_dry_grass.

Not yet tested. @Montandalar please test this. I will test when i have time.

@Montandalar
Copy link
Contributor

Grass spread from dirt_with_dry_grass to default:dirt, but not from dry_dirt_with_dry_grass to default dirt. I had to add dry_dirt_with_dry_grass to have spreading_dirt_type = 1 as a group as well (see my branch).

Paramat's branch - no growth from dry dirt:
screenshot_20200526_112444
My branch - growth from dry dirt as well:
screenshot_20200526_112634

@sfan5 sfan5 added the Feature label May 26, 2020
@paramat
Copy link
Contributor Author

paramat commented May 26, 2020

Thanks.

I had to add dry_dirt_with_dry_grass to have spreading_dirt_type = 1 as a group as well

Spreading from default:dry_dirt_with_dry_grass to default:dirt is not essential, as that combination is rare and this PR intends to restore spreading behaviour in old savanna areas.
Making default:dry_dirt_with_dry_grass a 'spreading_dirt_type' is unsuitable as it is not meant to spread.
So i prefer to leave this PR as it is. I will test it soon.

@paramat
Copy link
Contributor Author

paramat commented May 27, 2020

Tested and fine. I consider this mergeable.

screenshot_20200527_012059

Also tested that covered grasses are removed as expected:

screenshot_20200527_012421

@paramat paramat modified the milestone: 5.3.0 Jun 6, 2020
@paramat paramat added this to the 5.3.0 milestone Jun 16, 2020
@paramat
Copy link
Contributor Author

paramat commented Jun 16, 2020

Maybe merge for 5.3.0? Not high priority though.

@Montandalar
Copy link
Contributor

Montandalar commented Jun 16, 2020 via email

Copy link
Member

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I am also fine with merging this in feature freeze.

@paramat paramat removed this from the 5.3.0 milestone Jun 16, 2020
@paramat paramat merged commit e8a7e75 into minetest:master Jun 16, 2020
@paramat paramat deleted the drygrassspread branch November 4, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants