New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redo player_api #2745
Redo player_api #2745
Conversation
Possible compatibility breakage:
|
I have recently been studying the player_api mod closely over the last few weeks, because i am rewriting and improving it for use in new games. So i ask everyone, please wait until i have had time to review this PR before any possible merge. |
With all due respect for your work, the implementation of this feature takes approximately 5 minutes. I am also not satisfied with your implementation, which is why I have redone it. Differences (advantages, IMO): No |
I don't mind if the |
Co-authored-by: sfan5 <sfan5@live.de>
Sorry i was irritated. You have the right to offer an alternative implementation of course, it can just be a little irritating when that happens and i have the right to get irritated by that =) As a personal project i have been investigating how player_api could be improved for use in new games, so i really appreciate seeing work from others on this. Looking at your PR, it is certainly better code than my minimum-change alteration of player_api in #2743 , and fixes some other issues too, so i am closing my PR. |
So, my solution looks like this:
Performance could be increased by caching some sort of property combination ID which could then be compared in |
In my PR i discovered you cannot do boolean '==' or '~=' between the collision tables, so i ended up using |
Ready for merge. |
Bug: For the first time in a game session sleeping in a bed will not set the model. This doesn't seem to be caused by this PR however... |
It is not. It depends on whether you enter the bed in first-person mode, AFAIK. |
Bump. Merge conflicts resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works.
2d41c97
to
f558567
Compare
Last commit is untested and effectively implements #2751 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appears to work fine
I am still very curious why changing the player model (when entering a bed) does not work in third-person mode. This detail should be mostly invisible to the game. Edit: Okay that's obvious now. It works for everyone else but the client in question, |
set_local_animations
call