Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flowers: Add sporeless mushrooms #620

Closed
wants to merge 1 commit into from
Closed

Flowers: Add sporeless mushrooms #620

wants to merge 1 commit into from

Conversation

paramat
Copy link
Contributor

@paramat paramat commented Aug 10, 2015

'Fertile mushrooms' ('flowers:mushroom_fertile_brown/red') are placed by mapgen and the spore growing ABM.
These drop an infertile mushroom and 0 to 3 spores, with an average of just above 1 spore per mushroom for a slow multiplication of mushrooms when farming.

Infertile mushrooms do not drop spores to avoid the cheat of repeated digging and placing of a single mushroom to generate unlimited spores. These have the simpler technical name 'flowers:mushroom_brown/red' so that modders have a short name to work with in their recipies.

@est31
Copy link
Contributor

est31 commented Aug 10, 2015

Nice, the spore drop rate didn't change. With my commit, we had an expected value of

1 * 1/2 * 1/3 +
2 * 1/2 * 2/3 * 1/2 +
3 * 1/2 * 2/3 * 1/2 * 1/2 +
0 * 1/2 * 2/3 * 1/2 * 1/2

Which equals 0.75 spores per mushroom dug, and a chance of 0.5 to get a mushroom back. Your change has an expected value of

1 * 1/2 +
1 * 1/2 +
1 * 1/4

Which equals 1.25 spores. If you count the returned mushroom as one spore, you have 1.25 spores in average before and after.

👍 Like it

@paramat
Copy link
Contributor Author

paramat commented Aug 10, 2015

Heh the matching drop rate was by chance, i just thought 1.25 a reasonable average.
Thanks for spotting the cheat method.

@PilzAdam
Copy link
Contributor

👎 Leaves and grass work the same way. IMO it's not a cheat but a way to be able to farm stuff with minimal starting conditions.

@est31
Copy link
Contributor

est31 commented Aug 10, 2015

the cheat @paramat refers to was already fixed by 7066a6a (without dev discussion, admittedly). This PR is about returning mushrooms every time, and about actually discussing how to fix the cheat.

@est31 est31 changed the title Flowers: Add sporeless mushrooms to fix spore cheat Flowers: Add sporeless mushrooms Aug 10, 2015
@paramat
Copy link
Contributor Author

paramat commented Aug 10, 2015

PilzAdam okay, i'm personally not bothered about the 'cheat' so i'll return mushroom farming back to how it was originally, but keeping the 1.25 spore average. I assume i have approval from you to do that and will push within a day or so.

@est31
Copy link
Contributor

est31 commented Aug 10, 2015

let's add it to diamond ore too: if you mine diamond ore, you get one ore, and one diamond. I'm sure the game will be total fun!

@paramat
Copy link
Contributor Author

paramat commented Aug 10, 2015

Now tested.
Hmm ... PilzAdam i would rather mushroom farming was more challenging, the cheat makes it too easy and therefore a little shallow and dull, although i'm not suggesting we change leaves and grasses. For the moment i'll leave this commit as it is and wait for input from other MTGame devs.

@paramat paramat closed this Aug 11, 2015
@paramat paramat reopened this Aug 11, 2015
@paramat
Copy link
Contributor Author

paramat commented Aug 11, 2015

@PilzAdam leaves and grasses work differently as they drop themselves or sapling/seeds. The initial mushroom farming method allowed a single mushroom to be dug and placed repeatedly to generate infinite spores, mushrooms drop themselves and spores. This commit means a slow multiplication of mushrooms with effort and time.

@paramat paramat changed the title Flowers: Add sporeless mushrooms Flowers: Add sporeless mushrooms WIP Aug 12, 2015
@paramat
Copy link
Contributor Author

paramat commented Aug 12, 2015

WIP
I'm thinking of renaming the dropped mushrooms to simply 'mushroom_brown/red' so that modders do not have to use the 'sporeless' name. Then the other mushrooms would be called 'mushroom_mapgen_brown/red' or whatever.

@paramat
Copy link
Contributor Author

paramat commented Aug 12, 2015

Updated and tested, ready for merge.

@paramat paramat changed the title Flowers: Add sporeless mushrooms WIP Flowers: Add sporeless mushrooms Aug 12, 2015
@paramat
Copy link
Contributor Author

paramat commented Aug 13, 2015

Updated mushroom names, made fertile/mapgen mushrooms 'not in creative inventory'.
Discussion http://irc.minetest.ru/minetest-dev/2015-08-13#i_4364264

@paramat
Copy link
Contributor Author

paramat commented Aug 14, 2015

408ee69

@paramat paramat closed this Aug 14, 2015
@paramat paramat deleted the fixsporecheat branch August 14, 2015 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants