Default/mapgen: Remove unused 'mapgen_air' alias #784
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,7 +2,6 @@ | |||
| -- Aliases for map generator outputs | |||
| -- | |||
|
|
|||
| minetest.register_alias("mapgen_air", "air") | |||
|
It's unused. That was added as i was intending to alter all existing core mapgens to be able to use custom atmosphere nodes, for example to use mgv5 as a space mapgen. However that project turned out too difficult due to how existing core mapgens are built around a hardcoded "air" node. Instead i plan to add a dedicated lunar mapgen, for which a vacuum node and alias is more suitable. |
|
You could add damage per second (like lava does) and kill the player immediately (a suddenly appeared 1m³ vacuum immediately causes a damaging implosion, doesn't it? |
paramat
changed the title
|
PR changed to just remove the unused 'mapgen_air' alias. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: PR changed to just remove the unused 'mapgen_air' alias.