Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Farming: Add quiet sounds to seeds #1050

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@paramat
Copy link
Member

commented Apr 22, 2016

New version of PR #1000 to fix issue #997
Not high priority but simple and nice to have in release, so added milestone.
Sounds are defined as 'dirt defaults' to enable a dirt footstep, as seeds can only be placed on farming:soil. 'Dug' and 'place' sounds are as soft as possible while still being noticeable.
Tested.

@paramat paramat added this to the 0.4.14 milestone Apr 22, 2016

@C1ffisme

This comment has been minimized.

Copy link

commented Apr 22, 2016

Nah, come on. I usually throw seeds at breakneck speed into the ground. They always make a big loud sound.

👍 anyway.

@sofar

This comment has been minimized.

Copy link
Member

commented Apr 23, 2016

sure. this is trivial enough to merge with one approval, I'd think. Not like it can't be tweaked later trivially either.

@paramat

This comment has been minimized.

Copy link
Member Author

commented Apr 23, 2016

Yeah will merge as trivial.

@sfan5 sfan5 added >= Two approvals and removed One approval labels Apr 23, 2016

@sfan5

This comment has been minimized.

Copy link
Member

commented Apr 23, 2016

👍

@paramat

This comment has been minimized.

Copy link
Member Author

commented Apr 23, 2016

@paramat paramat closed this Apr 23, 2016

@paramat paramat referenced this pull request Apr 23, 2016

Closed

No sound placing seeds. #997

@paramat paramat deleted the paramat:seedsound branch Apr 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.