Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show item overlay if slot is occupied (bookshelf, vessels shelf) #1372

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@sfan5
Copy link
Member

sfan5 commented Nov 6, 2016

Implements the idea by @Rui-Minetest and fixes #1359.

screenshot_20161106_213549

screenshot_20161106_213554

@sfan5 sfan5 added the Low priority label Nov 6, 2016

@sofar

This comment has been minimized.

Copy link
Member

sofar commented Nov 6, 2016

Yeah, that's nice. 👍 on the idea, didn't see the code.

@paramat

This comment has been minimized.

Copy link
Member

paramat commented Nov 7, 2016

Good idea. Don't feel i can review as i'm useless with formspec stuff.

@Wuzzy2

This comment has been minimized.

Copy link
Contributor

Wuzzy2 commented Nov 7, 2016

Oh, I haven't realized this is even possible. But when I look at the code, it all seems so obvious now. :D
Thank you..

@Fixer-007

This comment has been minimized.

Copy link
Contributor

Fixer-007 commented Nov 7, 2016

Very nice idea :)

@Moufu5

This comment has been minimized.

Copy link
Contributor

Moufu5 commented Nov 7, 2016

Thanks, @sfan5 :)

@sfan5 sfan5 force-pushed the sfan5:overlayimg branch from e90dd86 to a7d274e Nov 9, 2016

@sfan5 sfan5 removed the Rebase needed label Nov 9, 2016

@paramat

This comment has been minimized.

Copy link
Member

paramat commented Nov 10, 2016

👍

@sofar

This comment has been minimized.

Copy link
Member

sofar commented Nov 14, 2016

👍

@sofar sofar added >= Two approvals and removed One approval labels Nov 14, 2016

@sfan5

This comment has been minimized.

Copy link
Member Author

sfan5 commented Nov 14, 2016

@sfan5 sfan5 closed this Nov 14, 2016

@sfan5 sfan5 deleted the sfan5:overlayimg branch Dec 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.