Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boats / carts: Fix on_punch functions #1427

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@paramat
Copy link
Member

commented Nov 29, 2016

Boats:
Previously, boats were not added to inventory in creative mode, fix.
In creative mode multiple boats will not be added to inventory.
Add comment.

Carts:
Set speed to 2 if punched by a non-player, to match the effect of a
player punch.
Add comments.
//////////////////////////////////////////////

Addresses #1426 by using the code from carts.
Plus some other fixes and improvements.

@paramat paramat added the Bugfix label Nov 29, 2016

@paramat paramat added this to the 0.4.15 milestone Nov 29, 2016

@paramat paramat added the WIP label Nov 30, 2016

@paramat paramat force-pushed the paramat:boatdig branch 2 times, most recently from 5a463d4 to 75f2b3e Nov 30, 2016

@paramat paramat changed the title Boats: Fix player-attached dig pickup in creative mode Boats / carts: Fix on_punch functions Nov 30, 2016

@paramat paramat removed the WIP label Nov 30, 2016

@paramat

This comment has been minimized.

Copy link
Member Author

commented Nov 30, 2016

Updated PR to improve carts on_punch function too.

@paramat paramat added the WIP label Nov 30, 2016

@paramat paramat force-pushed the paramat:boatdig branch 2 times, most recently from cb47242 to ba35ff8 Nov 30, 2016

@paramat paramat added WIP and removed WIP labels Nov 30, 2016

@paramat paramat force-pushed the paramat:boatdig branch from ba35ff8 to 32818ca Nov 30, 2016

Boats / carts: Fix and improve on_punch functions
Boats:
Previously, boats were not added to inventory in creative mode, fix.
In creative mode multiple boats will not be added to inventory.
Add comment.

Carts:
Set speed to 2 if punched by a non-player, to match the effect of a
player punch.
Add comments.

@paramat paramat force-pushed the paramat:boatdig branch from 32818ca to 9b45deb Nov 30, 2016

@paramat paramat removed the WIP label Nov 30, 2016

@sofar

This comment has been minimized.

Copy link
Member

commented Nov 30, 2016

Ok, looks fine to me. 👍

@paramat

This comment has been minimized.

Copy link
Member Author

commented Nov 30, 2016

Updated again, my changes broke something.

@paramat

This comment has been minimized.

Copy link
Member Author

commented Nov 30, 2016

Tested and ok.

@paramat

This comment has been minimized.

Copy link
Member Author

commented Nov 30, 2016

@paramat paramat closed this Nov 30, 2016

@paramat paramat deleted the paramat:boatdig branch Dec 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.