Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten chest open/close sounds. #1892

Closed
wants to merge 2 commits into from
Closed

Shorten chest open/close sounds. #1892

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 13, 2017

Good for opening multiple chests one after another, omits some creaking, the length is shortened. Further modification can be made.

@paramat
Copy link
Contributor

paramat commented Sep 13, 2017

I agree that our current chest sound has a little too much squeak to it.
Related #1824

@TumeniNodes
Copy link
Contributor

TumeniNodes commented Sep 14, 2017

these sound, and work well. I'm glad some squeak/creak was left in. +1

@paramat
Copy link
Contributor

paramat commented Sep 14, 2017

The open sound is much better, i don't like the end of our current creak, too long too (sorry sofar).
The close sound is fine too.
I think these are better than #1824
I assume the volume is unchanged? If so 👍

@ghost
Copy link
Author

ghost commented Sep 14, 2017

I assume the volume is unchanged?

Correct, only the length of the sounds were adjusted.

@Desour
Copy link
Member

Desour commented Sep 14, 2017

Imho the squeak sounds good. 👎
Edit: I'm neutral now.

@TumeniNodes
Copy link
Contributor

@jastevenson303
I think, if you redo the close file, leaving a bit of the creak (reverse of the open file) and shorten it the same, this would probably push through quickly ; )
Seems some like the creak on both open and close. Which sort of makes sense. But the shorter sounds work well

@ghost
Copy link
Author

ghost commented Sep 18, 2017

Yep, I just trimmed the originals a bit to suit, and tried it in-game and felt it was "good enough." Then I created this pull request so that I could favorite minetest on my github dashboard.

Anywhos, I will gladly try your recommendations @TumeniNodes and post a link back here when I do.

My thinking behind these here open/close sounds was: slowly opening chest = creak; quickly slamming shut = thud. I can totally get behind creaking on open and close and focus more on simply reducing duration, without altering so much of the "apparent" sound. Thanks.

@paramat paramat added WIP and removed One approval labels Sep 18, 2017
@paramat
Copy link
Contributor

paramat commented Sep 18, 2017

Since you seem to be updating, removed my +1, but will probably re-add it later.

This time, instead of just trimming, I adjusted the levels throughout,
as well as the speed, and overall duration; while trying to keep to
the original character of the sound.
@ghost
Copy link
Author

ghost commented Sep 20, 2017

Updated @paramat @TumeniNodes @DS-Minetest

screenshot from 2017-09-20 02-52-37

@ghost
Copy link
Author

ghost commented Sep 20, 2017

@paramat please remove the wip label. Thanks in advance.

Ps. Here is a video preview of the sounds: https://youtu.be/r6MApg0BmGs

@paramat paramat removed the WIP label Sep 20, 2017
@paramat
Copy link
Contributor

paramat commented Sep 25, 2017

👍

@Xaleth
Copy link

Xaleth commented Oct 22, 2017

If this PR is approved, then why is it not being merged?????

@paramat
Copy link
Contributor

paramat commented Oct 22, 2017

PRs require 2 approvals from MTG core devs.

@paramat
Copy link
Contributor

paramat commented Oct 22, 2017

@NewbProgrammer101 please stop the unnecessary spammy comments, thank you.

@Xaleth
Copy link

Xaleth commented Oct 22, 2017

Fine.

@minetest minetest deleted a comment from Xaleth Oct 23, 2017
@paramat
Copy link
Contributor

paramat commented Oct 23, 2017

Deleted the unnecessary comment. To be clear the first was ok.

@paramat
Copy link
Contributor

paramat commented Oct 23, 2017

7c3854d

@paramat paramat closed this Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants