Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not give creative priv to admin. #1905

Closed
wants to merge 1 commit into from

Conversation

@lhofhansl
Copy link
Contributor

commented Sep 29, 2017

Related to minetest #6460

Admin does not get creative priv by default (which changes gameplay in annoying ways), but can still grant it to self.

@lhofhansl

This comment has been minimized.

Copy link
Contributor Author

commented Sep 29, 2017

Turns out that this has to be done in every mod that define a priv that changes game behavior.

@SmallJoker

This comment has been minimized.

Copy link
Member

commented Oct 7, 2017

Obsolete PR. give_to_admin defaults to give_to_singleplayer.

@SmallJoker SmallJoker closed this Oct 7, 2017

@lhofhansl

This comment has been minimized.

Copy link
Contributor Author

commented Oct 7, 2017

Not sure this should be obsolete. The defaulting is done so that mods to not have to change anything. Admin and singleplayer should still be called out independently, IMHO.

@SmallJoker

This comment has been minimized.

Copy link
Member

commented Oct 7, 2017

I agree that extending it by explicit parameters is easier to understand how it works.
This is a trivial change without any effect so why not? shrug
Will merge in the next minutes.
Merged as 12a9716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.