Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boats: Prevent entering 'ignore' nodes #2044

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
1 participant
@paramat
Copy link
Member

commented Feb 9, 2018

At world edge make boat bounce back into world by inverting speed.
At world base avoid falling into ignore by setting y velocity to 0.
//////////////////

As part of world edge stuff minetest/minetest#6984
Should be merged if minetest/minetest#6998 is. Should be tested with that applied but not at the 31000 edge, set 'mapgen_limit' to a smaller value and test at a less distant world edge (at the 31000 world edge other code automatically deletes the boat entity).

It will be rare that a boat is used to drop into void at world base, but i added protection against that anyway, y velocity is set to zero. I did try a vertical bounce but this had no advantage and often resulted in a boat having zero y velocity and stuck about 1 node below world base. So at world base it is necessary for the player to exit the boat, pick it up and jump back up into the world.

@paramat paramat added the Bugfix label Feb 9, 2018

@paramat paramat added the WIP label Feb 10, 2018

@paramat paramat force-pushed the paramat:boatignore branch 2 times, most recently from 0abb787 to eaf168f Feb 10, 2018

@paramat paramat added WIP and removed WIP labels Feb 10, 2018

Boats: Prevent entering 'ignore' nodes
At world edge make boat bounce back into world by inverting speed.
At world base avoid falling into ignore by setting y velocity to 0.

@paramat paramat force-pushed the paramat:boatignore branch from eaf168f to 4009fa0 Feb 10, 2018

@paramat paramat changed the title Boats: Prevent motion in 'ignore' nodes Boats: Prevent entering 'ignore' nodes Feb 10, 2018

@paramat paramat removed the WIP label Feb 10, 2018

@paramat paramat added the Trivial label Feb 14, 2018

@paramat

This comment has been minimized.

Copy link
Member Author

commented Feb 17, 2018

@paramat paramat closed this Feb 17, 2018

@paramat paramat deleted the paramat:boatignore branch Feb 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.