Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beds: Add white simple and fancy beds #2150

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@paramat
Copy link
Member

commented Jun 17, 2018

Beds: Add white simple and fancy beds

Crafted from white wool so red dye is not required.
Describe red beds as 'Red'.
/////////////////////

screenshot_20180617_204841

For #475 so that red dye is not required to craft a bed (which is of course ridiculous).
Please see issue to consider the issues.
Adds a white bed, using textures by hkzorman from PR #2052
Code is a simple copy-paste-edit of the existing bed.
Something more original for MT as an alternative to copying MC's red bed.

@paramat paramat added the Feature label Jun 17, 2018

@paanrama

This comment has been minimized.

Copy link

commented Jun 19, 2018

I don't dislike it, but needs a bigger pillow because it looks too flat

@paanrama

This comment has been minimized.

Copy link

commented Jun 19, 2018

I understand the reason, and like the white ones more than the original red ones. I only try to say that when I see the white beds, for first time I notice that the beds don't have a pillow :).

@paramat

This comment has been minimized.

Copy link
Member Author

commented Jun 19, 2018

1 more nodebox on the fancy bed will add a pillow without needing to change textures :)

@paramat

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2018

We could even add a pillow to the simple bed too. Another PR though.

@paramat paramat added this to the 5.0.0 milestone Jul 9, 2018

Beds: Add white simple and fancy beds
Crafted from white wool so red dye is not required.
Describe red beds as 'Red'.

@paramat paramat force-pushed the paramat:whitebed branch from e8e9e36 to ba14053 Sep 14, 2018

@paramat

This comment has been minimized.

Copy link
Member Author

commented Sep 14, 2018

Updated to also describe red beds as 'Red'.

@paramat paramat removed this from the 5.0.0 milestone Sep 14, 2018

@12Me21

This comment has been minimized.

Copy link
Contributor

commented Sep 30, 2018

You could use palettes to allow different bed colors without adding more nodes.

@paramat

This comment has been minimized.

Copy link
Member Author

commented Oct 13, 2018

Any core dev opinions?

@Ezhh

This comment has been minimized.

Copy link
Member

commented Oct 14, 2018

I'm really unsure what I think. It's silly that beds require dye, but on the other hand a white bed doesn't look great (and beds of every colour always felt excessive to me).

Wouldn't it be more interesting to have something like a sleeping bag as the simple/no-dye sleeping option, then you progress to beds a bit later? Sure, the beds would still need dye that way, but you could set a sleeping spot without needing to meet the dye requirement.

@paramat

This comment has been minimized.

Copy link
Member Author

commented Oct 14, 2018

I like the idea of a sleeping bag.

@LoneWolfHT

This comment has been minimized.

Copy link

commented Oct 17, 2018

Why not redo the bed model or change the textures?

@paramat

This comment has been minimized.

Copy link
Member Author

commented Oct 17, 2018

Although i like the sleeping bag idea, it would require changes to player position when sleeping, which is not definable when registering. For a low priority issue i can't be bothered to code that, so i'll stick with a white bed.
I know it doesn't look great but it's only for those occasions where a player doesn't have red dye, in which case they will be glad to have a white bed available.

The other alternative i would consider is to not require red wool for the red bed, but that might conflict with recipes of some bed mods, and seems a little weird as red wool seems intuitive for a red bed.

@LoneWolfHT

This comment has been minimized.

Copy link

commented Oct 17, 2018

Or you could turn it into a black bed. Coal isn't hard to find

@paramat

This comment has been minimized.

Copy link
Member Author

commented Oct 28, 2018

Closing because 'meh ..' :) Very minor issue and not sure i want to add a new bed to solve it.

@paramat paramat closed this Oct 28, 2018

@paramat

This comment has been minimized.

Copy link
Member Author

commented Feb 8, 2019

Well, still unsure so re-opening for consideration.

@paramat paramat reopened this Feb 8, 2019

@LoneWolfHT

This comment has been minimized.

Copy link

commented Feb 8, 2019

I would be fine with a white bed. If you don't like the color you could make/use a mod that adds some more colors or changes the current color

@paramat

This comment has been minimized.

Copy link
Member Author

commented Feb 8, 2019

Here's a simpler alternative i prefer #475 (comment) so closing again.

@paramat paramat closed this Feb 9, 2019

@paramat paramat deleted the paramat:whitebed branch Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.